[Bug 247763] [patch] math/suitesparse: build fails because of implicit conversion from long to double

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=247763

            Bug ID: 247763
           Summary: [patch] math/suitesparse: build fails because of
                    implicit conversion from long to double
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: fortran at FreeBSD.org
          Reporter: rsmith at xs4all.nl
             Flags: maintainer-feedback?(fortran at FreeBSD.org)
          Assignee: fortran at FreeBSD.org
 Attachment #216198 text/plain
         mime type:

Created attachment 216198
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=216198&action=edit
Patch for in /usr/ports/math/suitesparse/files.

When building the new suitesparse 5.8.0, I get the following error:

gmake[4]: Entering directory
'/usr/ports/math/suitesparse/work/SuiteSparse-5.8.0/SLIP_LU/Lib'
gmake install INSTALL=/usr/ports/math/suitesparse/work/SuiteSparse-5.8.0
gmake[5]: Entering directory
'/usr/ports/math/suitesparse/work/SuiteSparse-5.8.0/SLIP_LU/Lib'
cc -O2 -pipe  -fstack-protector-strong -isystem /usr/local/include
-fno-strict-aliasing  -Wall -Wextra -Wpedantic -Werror -Wall -Wextra -Wpedantic
-Werror -isystem /usr/local/include  -O3 -fexceptions -fPIC -fopenmp
-I../Include -I../../COLAMD/Include -I../../AMD/Include
-I../../SuiteSparse_config  -c ../Source/slip_matrix_div.c
cc -O2 -pipe  -fstack-protector-strong -isystem /usr/local/include
-fno-strict-aliasing  -Wall -Wextra -Wpedantic -Werror -Wall -Wextra -Wpedantic
-Werror -isystem /usr/local/include  -O3 -fexceptions -fPIC -fopenmp
-I../Include -I../../COLAMD/Include -I../../AMD/Include
-I../../SuiteSparse_config  -c ../Source/slip_create_mpq_array.c
cc -O2 -pipe  -fstack-protector-strong -isystem /usr/local/include
-fno-strict-aliasing  -Wall -Wextra -Wpedantic -Werror -Wall -Wextra -Wpedantic
-Werror -isystem /usr/local/include  -O3 -fexceptions -fPIC -fopenmp
-I../Include -I../../COLAMD/Include -I../../AMD/Include
-I../../SuiteSparse_config  -c ../Source/SLIP_free.c
cc -O2 -pipe  -fstack-protector-strong -isystem /usr/local/include
-fno-strict-aliasing  -Wall -Wextra -Wpedantic -Werror -Wall -Wextra -Wpedantic
-Werror -isystem /usr/local/include  -O3 -fexceptions -fPIC -fopenmp
-I../Include -I../../COLAMD/Include -I../../AMD/Include
-I../../SuiteSparse_config  -c ../Source/SLIP_LU_factorize.c
In file included from ../Source/slip_create_mpq_array.c:15:
../Source/slip_internal.h:663:18: error: implicit conversion from 'long' to
'double' changes value from
      9223372036854775807 to 9223372036854775808
[-Werror,-Wimplicit-int-float-conversion]
    else if (x > INT64_MAX)
               ~ ^~~~~~~~~
/usr/include/x86/_stdint.h:90:19: note: expanded from macro 'INT64_MAX'
#define INT64_MAX       0x7fffffffffffffff
                        ^~~~~~~~~~~~~~~~~~
In file included from ../Source/slip_matrix_div.c:26:
../Source/slip_internal.h:663:18: error: implicit conversion from In file
included from ../Source/SLIP_free.c:13:
../Source/slip_internal.h:663:18: error: implicit conversion from 'long' to
'double' changes value from
      9223372036854775807 to 9223372036854775808
[-Werror,-Wimplicit-int-float-conversion]
'long'    else if (x > INT64_MAX)
               ~ ^~~~~~~~~
 /usr/include/x86/_stdint.h:90:19: note: expanded from macro 'INT64_MAX'
to#define INT64_MAX       0x7fffffffffffffff
                        ^~~~~~~~~~~~~~~~~~
 'double' changes value from
      9223372036854775807 to 9223372036854775808
[-Werror,-Wimplicit-int-float-conversion]
    else if (x > INT64_MAX)
               ~ ^~~~~~~~~
/usr/include/x86/_stdint.h:90:19: note: expanded from macro 'INT64_MAX'
#define INT64_MAX       0x7fffffffffffffff1 error generated.

                        ^~~~~~~~~~~~~~~~~~
1 error generated.
In file included from ../Source/SLIP_LU_factorize.c:40:
../Source/slip_internal.h:663:18: error: implicit conversion from 'long' to
'double' changes value from
      9223372036854775807 to 9223372036854775808
[-Werror,-Wimplicit-int-float-conversion]
    else if (x > INT64_MAX)
               ~ ^~~~~~~~~
/usr/include/x86/_stdint.h:90:19: note: expanded from macro 'INT64_MAX'
gmake[5]: *** [Makefile:46: SLIP_free.o] Error 1
#define INT64_MAX       0x7fffffffffffffffgmake[5]: *** Waiting for unfinished
jobs....

                        ^~~~~~~~~~~~~~~~~~
gmake[5]: *** [Makefile:46: slip_create_mpq_array.o] Error 1
1 error generated.
gmake[5]: *** [Makefile:46: slip_matrix_div.o] Error 1
1 error generated.
gmake[5]: *** [Makefile:46: SLIP_LU_factorize.o] Error 1
gmake[5]: Leaving directory
'/usr/ports/math/suitesparse/work/SuiteSparse-5.8.0/SLIP_LU/Lib'
gmake[4]: *** [Makefile:53: library] Error 2
gmake[4]: Leaving directory
'/usr/ports/math/suitesparse/work/SuiteSparse-5.8.0/SLIP_LU/Lib'
gmake[3]: *** [Makefile:32: library] Error 2
gmake[3]: Leaving directory
'/usr/ports/math/suitesparse/work/SuiteSparse-5.8.0/SLIP_LU'
gmake[2]: *** [Makefile:144: library] Error 2
gmake[2]: Leaving directory
'/usr/ports/math/suitesparse/work/SuiteSparse-5.8.0'
===> Compilation failed unexpectedly.
Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to
the maintainer.
*** Error code 1

Stop.
make[1]: stopped in /usr/ports/math/suitesparse
*** Error code 1

Stop.
make: stopped in /usr/ports/math/suitesparse

A small modification to slip__internal.h (making the conversion explicit) fixes
this issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.