Wine 5.9 bugfix

[Konstantin Belousov]

On Sat, May 23, 2020 at 11:45:43AM +0200, Damjan Jovanovic wrote:
> Hi
> 
> Wine 5.9 is out, and all 3 of the bugs in 5.7 - 5.8 that were affecting
> FreeBSD should be fixed upstream now.
> 
> However I accidentally introduced another bug recently, where we don't
> check the return value from an mmap() call, resulting in assertion failures
> and possibly memory corruption... I debugged it and a patch to fix it is
> available (https://source.winehq.org/patches/data/185684). Please build
> ports with that patch applied to 5.9. Sorry.
> 
> Otherwise 5.9 should be a really good release: it loads DLLs at correct
> addresses on FreeBSD, something Linux did better than us before, but we
> caught up now ;). Some of the more difficult applications like Cygwin and
> some copy-protected games should start working.
> 
> Also Konstantin and other developers have fixed that rtld-elf issue in the
> base system by changing link_map.l_addr to work the way it does on
> Linux/NetBSD/Illumos (
> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246561), which means Wine
> will crash on start again in the next FreeBSD release (which is? 13?) as
The fix should appear in stable/12 in one week, assuming no further
regressions are reported.  This means that the earliest release is 12.2.

> the workaround we added to Wine for FreeBSD will be wrong, and we have to
> limit that code in Wine (commit 0fd3f0266e05f6afa710fa2b5a254b0ed88bac0f)
> to FreeBSD versions less than the next release.