emulators/virtualbox-ose doesn't compile with libiconv

Jung-uk Kim jkim at FreeBSD.org
Fri Feb 21 19:13:38 UTC 2014


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2014-02-21 13:48:53 -0500, Tijl Coosemans wrote:
> On Fri, 21 Feb 2014 13:10:56 -0500 Jung-uk Kim wrote:
>> On 2014-02-21 11:42:51 -0500, Tijl Coosemans wrote:
>>> On Fri, 21 Feb 2014 17:00:46 +0100 Tijl Coosemans wrote:
>>>> On Mon, 10 Feb 2014 19:17:12 +0100 Tomasz Sowa wrote:
>>>>> emulators/virtualbox-ose doesn't compile when 
>>>>> converters/libiconv is installed:
>>>> 
>>>> Please try the attached patch for the port Makefile.
>>> 
>>> Sorry, that one was incomplete.  This one should work better.
>> 
>> Actually, I fixed it in my tree little differently.
>> 
>> https://redports.org/changeset?reponame=&new=23380%40jkim%2Femulators&old=22447%40jkim%2Femulators
>
>> 
> As long as you define LIBICONV_PLUG or replace <iconv.h> with 
> </usr/include/iconv.h> you're fine.  I would define LIBICONV_PLUG 
> only if ICONV_LIB is empty though so you always use libiconv_open 
> and libiconv_close etc. with libiconv.  iconv_open and iconv_close 
> work with libiconv too but they are also what base iconv uses so 
> there's a higher risk of trouble.

Done.

https://redports.org/changeset/23406/jkim

JK
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (FreeBSD)

iQEcBAEBAgAGBQJTB6VhAAoJEHyflib82/FGakIH/2Z3vCYttYaxeihULI79/kbh
YhchYLJWYQ09hKGhz5EdnCyDW4/HHn8zsplHpyCfIE7WtNxJl3nDBIJMKtsSuSXN
lIyKq7t8VTl7LCCfgvocvhGJqv3PxCk4yf7LMP8VvC3ewdyn8eLNHkc+UzFcqmaO
9fSlL1RAJGD+q84iOWoeGgYr6z2UXGfj7g7IKPdfF1uoBQJKt0UQJBOZZSyes+QV
QOUSwthTjQ4RNkOIoz3RjOKbqMeKCG763t/nXDxyF6GjnvVLF4HZMdU2LcJU5pCC
0mj/Qu6Iq3r/HoHGM6Ozu24GO/C6Sl0PbKCPqDbQEEjkhlLtPbxuwVnAMiWhVw4=
=DI7j
-----END PGP SIGNATURE-----


More information about the freebsd-emulation mailing list