r208751 broke virtualbox-ose port

[Alexander Best]

hi there,

did anybody else running HEAD notice that commit r208751 broke the
virtualbox-ose port?


kBuild: Compiling VBoxOGLhostcrstate -
/usr/ports/emulators/virtualbox-ose/work/VirtualBox-3.2.4_OSE/src/VBox/GuestHost/OpenGL/state_tracker/state_snapshot.c
kBuild: Compiling HGSMIGuestR0Lib -
/usr/ports/emulators/virtualbox-ose/work/VirtualBox-3.2.4_OSE/src/VBox/GuestHost/HGSMI/HGSMICommon.cpp
In file included from
/usr/ports/emulators/virtualbox-ose/work/VirtualBox-3.2.4_OSE/src/VBox/GuestHost/HGSMI/HGSMICommon.cpp:20:
/sys/sys/libkern.h:95: error: previous declaration of 'void*
memchr(const void*, int, size_t)' with 'C++' linkage
/usr/ports/emulators/virtualbox-ose/work/VirtualBox-3.2.4_OSE/include/iprt/string.h:63:
error: conflicts with new declaration with 'C' linkage
kmk[2]: *** [/usr/ports/emulators/virtualbox-ose/work/VirtualBox-3.2.4_OSE/out/freebsd.amd64/release/obj/HGSMIGuestR0Lib/HGSMICommon.o]
Error 1
The failing command:
@c++ -c -O2 -fno-exceptions -fno-rtti -Wall -Wextra
-Wno-missing-field-initializers -Wno-unused -Wno-trigraphs
-fdiagnostics-show-option -Wpointer-arith -Winline -O2
-fno-format-extensions -fno-strict-aliasing -fno-common
-finline-limit=8000 -fno-stack-protector -O2 -mtune=generic
-fno-omit-frame-pointer -nostdinc -m64 --param inline-unit-growth=100
--param large-function-growth=1000 -fno-omit-frame-pointer
-mcmodel=kernel -mno-red-zone -mfpmath=387 -mno-sse -mno-sse2 -mno-mmx
-mno-3dnow -msoft-float -fno-asynchronous-unwind-tables -Wundef -I/sys
-I/sys/contrib/altq -I/sys/../include -I/usr/include
-I/usr/ports/emulators/virtualbox-ose/work/VirtualBox-3.2.4_OSE/include
-I/usr/ports/emulators/virtualbox-ose/work/VirtualBox-3.2.4_OSE/out/freebsd.amd64/release
-DVBOX -DVBOX_OSE -DVBOX_WITH_64_BITS_GUESTS -DVBOX_WITH_HARDENING
-DRTPATH_APP_PRIVATE=\"/usr/local/share/virtualbox-ose\"
-DRTPATH_APP_PRIVATE_ARCH=\"/usr/local/lib/virtualbox\"
-DRTPATH_SHARED_LIBS=\"/usr/local/lib/virtualbox\"
-DRTPATH_APP_DOCS=\"/usr/local/share/doc/virtualbox-ose\"
-DRT_OS_FREEBSD -D__FREEBSD__ -DRT_ARCH_AMD64 -D__AMD64__ -D_KERNEL
-DKLD_MODULE -DIN_RING0 -DIN_RT_R0 -DIN_GUEST -DIN_GUEST_R0
-Wp,-MD,/usr/ports/emulators/virtualbox-ose/work/VirtualBox-3.2.4_OSE/out/freebsd.amd64/release/obj/HGSMIGuestR0Lib/HGSMICommon.o.dep
-Wp,-MT,/usr/ports/emulators/virtualbox-ose/work/VirtualBox-3.2.4_OSE/out/freebsd.amd64/release/obj/HGSMIGuestR0Lib/HGSMICommon.o
-Wp,-MP -o /usr/ports/emulators/virtualbox-ose/work/VirtualBox-3.2.4_OSE/out/freebsd.amd64/release/obj/HGSMIGuestR0Lib/HGSMICommon.o
/usr/ports/emulators/virtualbox-ose/work/VirtualBox-3.2.4_OSE/src/VBox/GuestHost/HGSMI/HGSMICommon.cpp
kmk[2]: *** Waiting for unfinished jobs....
kmk[2]: Leaving directory
`/usr/ports/emulators/virtualbox-ose/work/VirtualBox-3.2.4_OSE'
kmk[2]: Entering directory
`/usr/ports/emulators/virtualbox-ose/work/VirtualBox-3.2.4_OSE'
kmk[2]: *** Exiting with status 2
kmk[1]: *** [pass_libraries_this] Error 2
kmk[1]: Leaving directory
`/usr/ports/emulators/virtualbox-ose/work/VirtualBox-3.2.4_OSE'
kmk: *** [pass_libraries_order] Error 2
*** Error code 2

Stop in /usr/ports/emulators/virtualbox-ose.
*** Error code 1

Stop in /usr/ports/emulators/virtualbox-ose.


since memchr() is now provided by libkern.h maybe removing the
prototype from emulators/virtualbox-ose/work/VirtualBox-3.2.4_OSE/include/iprt/string.h
might solve the issue?

cheers.

-- 
Alexander Best
-------------- next part --------------
--- /home/arundel/string.h	2010-06-23 00:23:50.000000000 +0200
+++ /usr/ports/emulators/virtualbox-ose/work/VirtualBox-3.2.4_OSE/include/iprt/string.h	2010-06-23 00:23:55.000000000 +0200
@@ -60,7 +60,6 @@
 #if    (defined(RT_OS_DARWIN) && defined(KERNEL)) \
     || (defined(RT_OS_FREEBSD) && defined(_KERNEL))
 RT_C_DECLS_BEGIN
-void *memchr(const void *pv, int ch, size_t cb);
 char *strpbrk(const char *pszStr, const char *pszChars);
 RT_C_DECLS_END
 #endif