Emulation of Linux V4L ioctls

[Alexander Leidinger]

Quoting "J.R. Oldroyd" <fbsd at opal.com> (from Thu, 19 Nov 2009 15:31:59 -0500):

> I have added support for emulation of the Linux V4L video ioctls
> in compat/linux/linux_ioctl.[ch].

Wow, great!

> I am not a committer; the work can be found here:
> 	http://opal.com/freebsd/sys/compat/linux/
> These diffs are made to the 8.0-rc3 sources.

Some things I noticed and worry about:
  - videodev.h does not have a license, did you generate it
    yourself or did you take it from somewhere?
  - Does it needs to be named videodev.h, or can it also be
    linux_videodev.h?
    (if we may want to install this header at some point in time,
    it should have a name compatible with linux, else we should
    maybe add a linux_ prefix for consistence and for making it
    very obvious what we are talking about)
  - Why are you using __s32 and so on instead of the normal
    fixed size int types? We also have lint for "linux int"
    and so on in other files.
  - On which architecture has this been tested?
  - Will it run in linux32 emulation on amd64?
  - Are those structures known in userland (and as such need to
    have a specific size)? If yes, do they have different sizes
    in linux depending if the kernel is a 64bit kernel (amd64)
    or 32bit kernel (x86)?
  - Has this been run through a "make universe"?

Bye,
Alexander.

-- 
	WARNING TO ALL PERSONNEL:

Firings will continue until morale improves.

http://www.Leidinger.net    Alexander @ Leidinger.net: PGP ID = B0063FE7
http://www.FreeBSD.org       netchild @ FreeBSD.org  : PGP ID = 72077137