[patch] Mk/bsd.linux-rpm.mk: introduce some linux-f8 infrastructure

[Boris Samorodov]

Alexander Leidinger <Alexander at Leidinger.net> writes:
> Quoting Boris Samorodov <bsam at ipt.ru> (from Wed, 04 Mar 2009 13:01:28 +0300):
>> Alexander Leidinger <Alexander at Leidinger.net> writes:
>>> Quoting Boris Samorodov <bsam at ipt.ru> (from Wed, 04 Mar 2009
>>> 12:23:35 +0300):
>>>> Alexander Leidinger <Alexander at Leidinger.net> writes:
>>>>> Quoting Boris Samorodov <bsam at ipt.ru> (from Tue, 03 Mar 2009
>>>
>>>>>> . define MASTER_SITE_SUBDIR and MASTER_SITE_SRC_SUBDIR when
>>>>>>   LINUX_DIST_VER=8 (no such ports ATM).
>>>>>
>>>>> Why is there ifndef MASTER_SITES (only in the context of your patch,
>>>>
>>>> This ifndef was introduced by sat@ at Rev 1.9. I'm not aware of the
>>>> real need.
>>>
>>> I had a look at it. It is about protecting MASTER_SITE_* to be set,
>>> e.g. imagine if someone sets MASTER_SITE=file:///..., and at this
>>> location there's a flat file structure. In this case you do not want
>>> to have MASTER_SITE_* to be set.
>>>
>>> So I think you need to change your patch to keep this functionality.
>>
>> Yes, good catch, thanks! The first .endif was misplaced. Seems that
>> the following patch is what you meant:
>
> Yes, looks commit ready.
>
> Personally I would remove the '?' from MASTER_SITE?=, as it is handled
> by the ifndef. This way it does not confuse readers. MAybe even
> putting a comment there what this is all about.

Fixed:
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Mk.diff
Type: text/x-patch
Size: 2050 bytes
Desc: a patch for bsd.linux-rpm.mk
Url : http://lists.freebsd.org/pipermail/freebsd-emulation/attachments/20090304/3449727c/Mk.bin
-------------- next part --------------


WBR
-- 
Boris Samorodov (bsam)
Research Engineer, http://www.ipt.ru Telephone & Internet SP
FreeBSD Committer, http://www.FreeBSD.org The Power To Serve