cvs commit: ports/ftp Makefile ports/ftp/linux-curl Makefile
distinfo.i386
Jose Alonso Cardenas Marquez
acm at FreeBSD.org
Mon Aug 7 01:12:14 UTC 2006
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On Mon, 07 Aug 2006 04:03:16 +0400
Boris Samorodov <bsam at ipt.ru> wrote:
> On Sun, 6 Aug 2006 17:45:43 -0500 Jose Alonso Cardenas Marquez wrote:
> > On Sun, 06 Aug 2006 15:15:08 +0400
> > Boris Samorodov <bsam at ipt.ru> wrote:
>
> Why did you use @dirrmtry at security/linux-krb5-libs/pkg-plist? ;-)
> Actually, it seems to me that when in doubt you prefer to use @dirrmty
> macro. I'd say that it should be quite the opposite. This macro should
> be used only when you are sure that those directories are shared
> between ports and there is no (so to say) "master port" which deals
> with those directories. My opinion is to use @dirrmtry with care...
Fixed. Maybe i don't need to work on security/linux-krb5-libs anymore,
because it could be on linux_base-fc4 soon ;)
> Good work! And here are some comments:
> - you didn't show a diff for the distinfo;
> - portrevision is not bumpted; ;-)
> - at pkg-install script only empty directories are created, so there
> is no need to create a usr/kerberos one;
> - assume that you didn't check linux_base-fc4.diff file on TB, because
> I can't manage to find a line with "@dirrm usr/kerberos" at the
> plist file.
I fixed all these points, you can see the TB log files.
http://hellfire.no-ip.org/tb/logs/4-STABLE/linux_base-fc-4_7.log
http://hellfire.no-ip.org/tb/logs/5-STABLE/linux_base-fc-4_7.log
http://hellfire.no-ip.org/tb/logs/6-STABLE/linux_base-fc-4_7.log
http://tb3.droso.net/logs/6-acm/linux_base-fc-4_7.log
and the new diff file
http://hellfire.no-ip.org/ports/linux_base-fc4.diff
> Other than that seems OK. May be Alexander has something to add.
> Thanks!
If every things are ok, i'll send one PR with this patch. Thanks for
your support :)
Greetings
- ----
Jose Alonso Cardenas Marquez | http://www.FreeBSD.org
acm at FreeBSD.org | http://www.BSD.org.pe
GnuPG Key: http://www.FreeBSD.org/~acm/pgp/pubkey.asc
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (FreeBSD)
iD8DBQFE1pNwGV/UqJshvBkRAlUxAJwLVtGcNPaUhoG6lrP2iVCd50riTwCbBKHk
ubj+5rulyAKPnEgnCMTkacM=
=VAHC
-----END PGP SIGNATURE-----
More information about the freebsd-emulation
mailing list