makefs(8) proposed changes [repost from fs@]

[Markus Hitter]

Am 15.10.2013 um 18:07 schrieb Sean Bruno:

> Index: ffs.c
> ===================================================================
> --- ffs.c       (revision 255871)
> +++ ffs.c       (working copy)
> @@ -470,6 +470,7 @@
>         char    *buf;
>         int     i, bufsize;
>         off_t   bufrem;
> +       char temp_buf[16*512];
>
>         assert (image != NULL);
>         assert (fsopts != NULL);
> @@ -480,6 +481,7 @@
>                 warn("Can't open `%s' for writing", image);
>                 return (-1);
>         }
> +       read(fsopts->fd, temp_buf, 16*512);
>
>                 /* zero image */
>  #if HAVE_STRUCT_STATVFS_F_IOSIZE && HAVE_FSTATVFS

Usually I'm only an observer here, but what's the point of reading 8  
kB without using them? There's also lseek(2).


Markus

- - - - - - - - - - - - - - - - - - -
Dipl. Ing. (FH) Markus Hitter
http://www.jump-ing.de/