r181397 of src/usr.bin/make/job.c breaks cross-compiles

[Ruslan Ermilov]

Hi,

On Mon, Sep 29, 2008 at 06:06:06AM +0400, Andrey Chernov wrote:
> On Mon, Sep 29, 2008 at 05:55:56AM +0400, Andrey Chernov wrote:
> > > It looks to me as if the change to "make" assumes that the FreeBSD 8.x 
> > > versions of the arc4 library functions are always available, even for 
> > > cross compilation. This assumption doesn't seem to be robust, and it 
> > > breaks down in this cross-compilation use case.
> > 
> > It not breaks because all is builded by old 'make' in 6, 7, and 8. New 
> > 'make' is not installed until the very final stage. I see no problem with 
> > cross-compilation in that way.
> 
> I just check cross-tools list in 6, 7 and 8 and not found 'make' there 
> too.
> 
The first thing buildworld does is to check if a passed instance of
`make' is good enough; if not, it's bootstrapped -- built and used
later in the process.  It's handled by the `upgrade_checks' target
in src/Makefile which buildworld depends on.

An ability to compile the latest make on the lowest supported version
of FreeBSD is a requirement of our build procedure.  If your change
doesn't meet it, you should really think of either backing it out,
or making it compile and work.  For RELENG_7 it's currently FreeBSD
5.3, for HEAD -- FreeBSD 6.0.


Cheers,
-- 
Ruslan Ermilov
ru at FreeBSD.org
FreeBSD committer