Allocating resources to isab children

[Henrik Brix Andersen]

On May 13, 2011, at 03:40, John Baldwin wrote:
> On 5/12/11 5:45 PM, Henrik Brix Andersen wrote:
>> 
>> Having completed the driver for the I2C host bus controller, I have revised the patch a little.
>> The updated patch is available at http://people.freebsd.org/~brix/src-patches/isa_pci.c.diff
> 
> A few cosmetic nits:
> 
> - I would use 'isab_pci_*' rather than 'isa_pci_*' as it is an ISA bridge rather than an ISA bus device.
> - You can probably leave out the blank line in isa[b]_pci_attach() between bus_generic_probe() and isab_attach().
> 
> Other than that, you are fine to commit this with a reviewed by from me.

Thank you, committed with the changes suggested above.

>> I would appreciate it if you could find the time to review this and - if possible - approve a commit of this patch.
>> 
>> The patch for the glxiic(4) I2C host bus driver is available at http://people.freebsd.org/~brix/src-patches/glxiic.diff - if somebody could find the time to review this as well, I would be very grateful. Since I do not have a commit bit for src, I will eventually need an approval for this to enter the tree as well.
> 
> This mostly looks good to me.  I can't evaluate the actual driver logic, but the new-bus, etc. bits look fine.  One thing is that since you use callout_init_mtx(), I don't think you need any of the callout stuff at the start of your timeout routine (callout_pending/active/deactivate). With callout_init_mtx() your callout will only be called if it is active.  That is the only nit that I saw however.

Ah, right - thanks. I have updated the patch and retested without issues.

Since it seems we lack an official iicbus(4) maintainer (?), perhaps I should post this patch on the freebsd-embedded@ mailing list for review (as the CS5536 and I2C are often found in combination on SBCs such as the Alix boards from PC Engines). Hopefully somebody will be able to review the actual driver logic and provide approval.

Regards,
Brix
-- 
Henrik Brix Andersen <brix at FreeBSD.org>



-------------- next part --------------
A non-text attachment was scrubbed...
Name: PGP.sig
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part
Url : http://lists.freebsd.org/pipermail/freebsd-drivers/attachments/20110513/1de6b68c/PGP.pgp