[Bug 206709] Ports links to long descriptions have revision parameter duplicated, confusing svnweb

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=206709

Andreas Perstinger <andipersti at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andipersti at gmail.com

--- Comment #1 from Andreas Perstinger <andipersti at gmail.com> ---
This bug affects every port which is listed in more than one category.

Another example would be Zope 2.13. This port is listed in 3 categories: 

Python: https://www.freebsd.org/ports/python.html#zope213-2.13.23 (generated
long description link:
https://svnweb.freebsd.org/ports/head/www/zope213/pkg-descr?revision=HEAD )

WWW: https://www.freebsd.org/ports/www.html#zope213-2.13.23 (generated long
description link:
https://svnweb.freebsd.org/ports/head/www/zope213/pkg-descr?revision=HEAD?revision=HEAD
)

Zope: https://www.freebsd.org/ports/zope.html#zope213-2.13.23 (generated long
description link:
https://svnweb.freebsd.org/ports/head/www/zope213/pkg-descr?revision=HEAD?revision=HEAD?revision=HEAD
)

As you can see, in each category another copy of the string "?revision=HEAD" is
appended to the link to the long description.

The bug is in
https://svnweb.freebsd.org/doc/head/en_US.ISO8859-1/htdocs/ports/portindex?view=markup
. On line 194, the loop goes through all the categories of a port (in
alphabetical order) and creates the output string for the web page. On line 200
the string "?revision=HEAD" is appended to the $ldesc string. But $ldesc
doesn't change inside the loop (except in the first iteration) thus more copies
are appended in each iteration.

IMHO most of the body of the foreach loop should be outside it because most
lines process the ports data in each iteration in the same way. Only line 195
and lines 241-258 should be inside the loop.

-- 
You are receiving this mail because:
You are the assignee for the bug.