docs/176455: [patch][book/porters-handbook] convert to optionsNG for NLS, fix a closed literal tag

Jason Helfman jgh at FreeBSD.org
Tue Feb 26 22:30:00 UTC 2013


>Number:         176455
>Category:       docs
>Synopsis:       [patch][book/porters-handbook] convert to optionsNG for NLS, fix a closed literal tag
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-doc
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Feb 26 22:30:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Jason Helfman
>Release:        FreeBSD 10.0-CURRENT amd64
>Organization:
>Environment:
System: FreeBSD freefall.freebsd.org 10.0-CURRENT FreeBSD 10.0-CURRENT #2 r245102: Sun Jan 6 15:01:33 UTC 2013 root at freefall.freebsd.org:/usr/obj/usr/src/sys/FREEFALL amd64


	
>Description:
NLS section example wasn't converted to new options framework
Encountered a issue when building where a closed "literal" tag was never opened. line 7608

/usr/local/bin/openjade:/home/jgh/workspace/docs/en_US.ISO8859-1/books/porters-handbook/book.xml:7608:10:E: end tag for element "literal" which is not open

>How-To-Repeat:
	
>Fix:

Index: book.xml
===================================================================
--- book.xml	(revision 41051)
+++ book.xml	(working copy)
@@ -5749,14 +5749,18 @@
 
 	<programlisting>GNU_CONFIGURE=		yes
 
-.if !defined(WITHOUT_NLS)
+.include <bsd.port.options.mk>
+
+.if ${PORT_OPTIONS:MNLS}
 USE_GETTEXT=		yes
 PLIST_SUB+=		NLS=""
 .else
 CONFIGURE_ARGS+=	--disable-nls
 PLIST_SUB+=		NLS="@comment "
-.endif</programlisting>
+.endif
 
+.include <bsd.port.mk></programlisting>
+
 	<para>The next item on your to-do list is to arrange so that
 	  the message catalog files are included in the packing list
 	  conditionally.  The <filename>Makefile</filename> part of
@@ -7599,6 +7603,12 @@
 
       <programlisting>PKGNAMEPREFIX=	${PYTHON_PKGNAMEPREFIX}</programlisting>
 
+      <para>Generally, if <makevar>PKGNAMEPREFIX</makevar> is set, the
+	port should require a <literal>py-</literal> port origin prefix.
+	For example, <filename>
+	/usr/ports/<replaceable>sysutils/py-myport</replaceable>
+	</filename></para>
+
       <table frame="none">
 	<title>Most Useful Variables for Ports That Use Python</title>
 
>Release-Note:
>Audit-Trail:
>Unformatted:


More information about the freebsd-doc mailing list