docs/173971: fdp-primer quick start section makes reference to 'make lint'

Eitan Adler lists at eitanadler.com
Wed Nov 28 17:00:01 UTC 2012


The following reply was made to PR docs/173971; it has been noted by GNATS.

From: Eitan Adler <lists at eitanadler.com>
To: Derek Wood <ddwood at outlook.com>, Hiroki Sato <hrs at freebsd.org>
Cc: bug-followup at freebsd.org
Subject: Re: docs/173971: fdp-primer quick start section makes reference to
 'make lint'
Date: Wed, 28 Nov 2012 11:59:13 -0500

 [ccing hrs as he is the one whom added the target in the first place]
 
 On 28 November 2012 10:40, Derek Wood <ddwood at outlook.com> wrote:
 > As per eadler@, 'make lint' in the FreeBSD document tree is broken, and the reference to it in the fdp-primer book ( http://www.freebsd.org/doc/en_US.ISO8859-1/books/fdp-primer/overview-quick-start.html ) is erroneous.
 >>How-To-Repeat:
 
 My understanding is that the "make lint" target is currently broken
 and non-useful.  If I am wrong and this target is intended to work
 please let me know.
 
 This patch removes the target and text explaining it.
 
 commit 2e984ecbace3df739ecf147c76fcd6d2645c33cb
 Author: Eitan Adler <lists at eitanadler.com>
 Date:   Wed Nov 28 11:57:26 2012 -0500
 
     Remove 'lint' make target which is currently broken and non-useful.
 
     PR:		docs/173971
     Submitted by:	Derek Wood <ddwood at outlook.com> (pr)
 
 diff --git a/en_US.ISO8859-1/books/fdp-primer/overview/chapter.xml
 b/en_US.ISO8859-1/books/fdp-primer/overview/chapter.xml
 index 2930c47..6fecb16 100644
 --- a/en_US.ISO8859-1/books/fdp-primer/overview/chapter.xml
 +++ b/en_US.ISO8859-1/books/fdp-primer/overview/chapter.xml
 @@ -257,13 +257,6 @@
        </step>
 
        <step>
 -	<para>Test the markup using the <maketarget>lint</maketarget>
 -	  target.  This will quickly find any errors in the document
 -	  without actually performing the time-consuming
 -	  transformation.</para>
 -
 -	<screen>&prompt.user; <userinput>make lint</userinput></screen>
 -
  	<para>When you are ready to actually build the document, you
  	  may specify a single format or a list of formats in the
  	  <varname>FORMATS</varname> variable.  Currently,
 diff --git a/share/mk/doc.xml.mk b/share/mk/doc.xml.mk
 index a749ae9..a4b1229 100644
 --- a/share/mk/doc.xml.mk
 +++ b/share/mk/doc.xml.mk
 @@ -373,13 +373,5 @@ ${TARGET.${_ID}}: ${XML.${_ID}} ${DEPENDS.${_ID}}
  	${XSLTPROC} ${XSLTPROCOPTS.${_ID}} \
  		-o ${.TARGET} ${PARAMS.${_ID}} \
  		${XSLT.${_ID}} ${XML.${_ID}}
 -
 -VALIDATE_DOCS+=	VALIDATE.${_ID}
 -VALIDATE.${_ID}:
 -	@${ECHO} "==>[xmllint] ${XML.${_ID}}"
 -	-@${XMLLINT} ${XMLLINTOPTS} ${XML.${_ID}} 2>&1  \
 -		| ${SED} -e 's/^/ | /'
  .  endfor
  .endfor
 -
 -lint: ${VALIDATE_DOCS}
 
 
 
 -- 
 Eitan Adler


More information about the freebsd-doc mailing list