Please review WINE chapter addition and linuxemu rename
Glen Barber
gjb at FreeBSD.org
Sat Jun 2 02:50:16 UTC 2012
Hi,
On Fri, Jun 01, 2012 at 08:05:09PM -0600, Warren Block wrote:
> On Fri, 1 Jun 2012, Ulrich Spörlein wrote:
>
> > in the process of adding the WINE section from the wiki to the handbook
> > (GCIN 2011 project, yeah I know, I was rather busy ...), I also took the
> > liberty of renaming it from linuxemu to compat. Also in the hope that
> > someday we might have a blurp on SVR4 compatibility, although I guess no
> > one is really interested in that.
> >
> > Anyway, please review the proposed changes at
> > https://github.com/uqs/freebsd-doc/commits/wine
> > or clone that branch and have a closer look.
>
> Like Gabor suggested, a single diff makes it easier to see all that has
> changed.
>
> > Rendering of that branch can be found here:
> > https://www.spoerlein.net/handbook/compat.html
>
> Just looking at the WINE section:
>
> "check the Wine AppDB on their main website."
>
> "their main website" could be removed.
>
> Those <programlistings> should be <screen> sections:
>
> <screen>&prompt.root; <userinput>chroot /compat/i386</userinput>
> &prompt.root; /etc/rc.d/ldconfig start</screen>
>
> And so on. Note that the ending tag should go on the last line of
> output. If it is on a line of its own, there's an extra blank line in
> the rendered version.
>
To add to Warren's style comments, there should be an empty line between
<title> and <para>. Similarly for <sect> tags.
The closing </para> tags should not be on a separate line alone.
It might be good to use " in place of literal double quotes
surrounding Wine is not an Emulator.
"make install clean" could be sgml-ified as:
<command>make</command> <maketarget>install clean</maketarget>
without quotes.
Regards,
Glen
More information about the freebsd-doc
mailing list