FreeBSD web build failed on red.freebsd.org

[Peter Wemm]

On Thu, Dec 27, 2012 at 8:16 AM, Simon L. B. Nielsen <simon at freebsd.org> wrote:
> On 25 December 2012 22:41, World Wide Web Owner <www at freebsd.org> wrote:
>> install -C   -o www -g wwwadm -m 664 /w/www/build/head/en_US.ISO8859-1/htdocs/releases/4.8R/relnotes-i386.html /usr/local/www/www.freebsd.org/data/releases/4.8R
>> ===> releases/4.9R
>> install -C   -o www -g wwwadm -m 664 /w/www/build/head/en_US.ISO8859-1/htdocs/releases/4.9R/announce.html /usr/local/www/www.freebsd.org/data/releases/4.9R
>> install -C   -o www -g wwwadm -m 664 /w/www/build/head/en_US.ISO8859-1/htdocs/releases/4.9R/hardware.html /usr/local/www/www.freebsd.org/data/releases/4.9R
>> install: wwwadm: Invalid argument
>> *** Error code 67
>
> Hey Peter,
>
> There have been a fair number of build failures like this recently. I
> wonder if there could be a race in the generation of the group file
> where it's invalid ?

I don't think so.. here's what it does:

if (!sysopen(MGR, "/etc/group", O_RDWR | O_EXLOCK | O_NONBLOCK)) {
..
sysopen(NGR, "/etc/group.new", O_RDWR | O_CREAT | O_TRUNC, 0644) ...
..
copies unmanaged things to group.new, and adds managed things to group.new
...
rename("/etc/group.new", "/etc/group") || die "Could not rename
/etc/group.new to /etc/group: $!";
close(MGR);
close(NGR);

So at no point should there ever be an invalid /etc/group file.  The
lockf on group is what happens when you vi it.

The libc code only seems to be able to throw an EINVAL if something
like strtoul(3) can't parse an integer in a numeric base it
recognizes.  I've been scratching my head trying to guess where an
EINVAL might come from but I don't see it..  There should never ever
be a case where the groups file is partially complete.


-- 
Peter Wemm - peter at wemm.org; peter at FreeBSD.org; peter at yahoo-inc.com; KI6FJV
"All of this is for nothing if we don't go to the stars" - JMS/B5
"If Java had true garbage collection, most programs would delete
themselves upon execution." -- Robert Sewell
bitcoin:188ZjyYLFJiEheQZw4UtU27e2FMLmuRBUE