docs/112804: groff(1) command should be called to explicitly use "ps" as output

[ighighi]

>Number:         112804
>Category:       docs
>Synopsis:       groff(1) command should be called to explicitly use "ps" as output
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-doc
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun May 20 07:30:03 GMT 2007
>Closed-Date:
>Last-Modified:
>Originator:     ighighi
>Release:        6.2-STABLE
>Organization:
>Environment:
FreeBSD orion 6.2-STABLE FreeBSD 6.2-STABLE #1: Fri May 18 01:56:15 VET 2007     root at orion:/usr/obj/usr/src/sys/CUSTOM  i386
>Description:
The following line in /usr/share/mk/doc.images.mk should contain "-Tps" to prevent groff(1) from using the GROFF_TYPESETTER environment variable
PIC2PS?=       ${GROFF} -p -S -Wall -mtty-char -man

When set to something other than "ps" the build fails, so adding "-Tps" would
allow the user building the documentation have GROFF_TYPESETTER in ~/.profile
without interfering with the build.  I usually have this variable set to "latin1"
or "ascii" so "man -t whatever" makes groff(1) use any output device I want.
IMO, It doesn't hurt to add a "-Tps" to the line above as it would make the 
intended usage explicit.
>How-To-Repeat:
export GROFF_TYPESETTER=latin1 
cd /usr/doc
make FORMATS="html html-single"
>Fix:
Attached patch.

Patch attached with submission follows:

--- share/mk/doc.images.mk.orig	Fri Jul 23 14:58:56 2004
+++ share/mk/doc.images.mk	Fri May 18 13:10:56 2007
@@ -154,7 +154,7 @@
 EPSTOPDF?=	${PREFIX}/bin/epstopdf
 EPSTOPDFOPTS?=	${EPSTOPDFFLAGS}
 #
-PIC2PS?=	${GROFF} -p -S -Wall -mtty-char -man
+PIC2PS?=	${GROFF} -Tps -p -S -Wall -mtty-char -man
 #
 PS2EPS?=	${PREFIX}/bin/gs
 PS2EPSOPTS?=	-q -dNOPAUSE -dSAFER -dDELAYSAFER \

>Release-Note:
>Audit-Trail:
>Unformatted: