pr guidelines, DES's name...

[Ceri Davies]

On Thu, Nov 04, 2004 at 11:54:18AM +0200, Giorgos Keramidas wrote:
> On 2004-11-03 17:00, John-Mark Gurney <gurney_j at resnet.uoregon.edu> wrote:
> >Giorgos Keramidas wrote this message on Thu, Nov 04, 2004 at 02:44 +0200:
> >>On 2004-11-03 22:53, "Simon L. Nielsen" <simon at FreeBSD.org> wrote:
> >>>On 2004.11.03 13:31:53 -0800, John-Mark Gurney wrote:
> >>>> I just happen to notice that Mozilla 1.7.3 doesn't display des's
> >>>> last name properly on:
> >>>> http://www.freebsd.org/doc/en_US.ISO8859-1/articles/pr-guidelines/
> >>>
> >>> I think the real problem is that neither the webserver nor the
> >>> document sets the character set.  It should be iso8859-1 and not
> >>> utf-8, as can be seen from the directory name (en_US.ISO8859-1).
> >>>
> >>> I guess the right solution is to insert the proper metatag in the
> >>> headers to force iso8859-1.
> >>
> >> That's relatively easy to fix.  Any objections to the following patch to
> >> freebsd.dsl?
> >
> > not that I know it, but don't we need that to be applicable to only
> > docs gen'd under en_US.ISO8859-1?  Shouldn't we do something in the
> > makefile that defines the charset for each parent, and then use that
> > charset for all files generated from the dir?
> 
> You're right, of course.  We already have SP_ENCODING, but I don't know
> how to read its value from `freebsd.dsl'.  My DSSSL-foo is, I'm afraid,
> really minimal.

It's not reading the value from SP_ENCODING, but we already have a
doc.langcode entity in urls.ent, which could be overridden by
translations easily enough, so your patch becomes:

Index: freebsd.dsl
===================================================================
RCS file: /home/ncvs/doc/share/sgml/freebsd.dsl,v
retrieving revision 1.83
diff -u -r1.83 freebsd.dsl
--- freebsd.dsl	29 Oct 2004 15:36:27 -0000	1.83
+++ freebsd.dsl	4 Nov 2004 19:59:03 -0000
@@ -33,6 +33,10 @@
       <!-- HTML only .................................................... -->
       
       <![ %output.html; [
+
+	(define %gentext-language% "en")
+	(define %html-header-tags% '(("META" ("HTTP-EQUIV" "Content-Type") ("CONTENT" "text/html; charset=&doc.langcode"))))
+
         <!-- Configure the stylesheet using documented variables -->
 
         (define %hyphenation% #f)        <!-- Silence a warning -->

I haven't touched the %gentext-language% definition obviously, because
I'm not sure what it does.

Ceri
-- 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-doc/attachments/20041104/fde8a53a/attachment.sig>