[Review Request]: Kerberos5 final draft

[Tom Rhodes]

On Thu, 4 Sep 2003 21:07:35 +0200
Martin Heinen <martin at sumuk.de> wrote:

> On Thu, Sep 04, 2003 at 01:34:02PM -0400, Tom Rhodes wrote:
> 
> > Please see the diff and give me feedback.  This has already gone
> > through a good review on -doc so I'm only really waiting for Robert's
> > review.  Although I want to get any final comments or "please commit's"
> > now.
> 
> Here are my final markup nits, otherwise I'm fine:
> 
> > --- chapter.sgml	Thu Sep  4 13:12:30 2003
> > +++ chapter.new	Thu Sep  4 13:19:05 2003
> > @@ -106,7 +106,7 @@
> >        servers – meaning that external entities can connect and talk
> >        to them.  As yesterday's mini-computers and mainframes become
> >        today's desktops, and as computers become networked and
> > -      internetworked, security becomes an even bigger issue.</para>
> > +      inter-networked, security becomes an even bigger issue.</para>
> 
> This (still) should be a separate commit.

It will be as it is a spelling fix and the rest are content fixes.

> 
> > +      <screen>&prompt.user;<userinput>k5init <replaceable>tillman</replaceable></userinput>
> > +      tillman at EXAMPLE.ORG's Password:
> > +
> > +      &prompt.user;<userinput>k5list</userinput>
> > +      Credentials cache: FILE:<filename>/tmp/krb5cc_500</filename>
> > +      Principal: tillman at EXAMPLE.ORG</screen>
> > +
> > +      <screen>Issued           Expires          Principal
> > +              Aug 27 15:37:58  Aug 28 01:37:58  krbtgt/EXAMPLE.ORG at EXAMPLE.ORG
> > +              Aug 27 15:37:58  Aug 28 01:37:58  krbtgt/EXAMPLE.ORG at EXAMPLE.ORG</screen>
> > +
> > +      <screen>v4-ticket file: /tmp/tkt500
> > +      k5list: No ticket file (tf_util)</screen>
> 
> Why use multiple screen elements here?  All output
> is produced by the k5list command.  Therefore
> one screen element is sufficient.

Fixed.

> 
> > +	<screen>&prompt.root;kadmin
> 
> Missing space and userinput:
> 
>   &prompt.root; <userinput>kadmin</userinput>

Fixed.

> 
> > +	kadmin> add --random-key host/myserver.EXAMPLE.ORG
> > +	Max ticket life [unlimited]:
> > +	Max renewable life [unlimited]:
> > +	Attributes []:
> > +	kadmin> ext host/myserver.EXAMPLE.ORG
> > +	kadmin> exit</screen>
> 
> [ ... ]

Done.

> 
> > +	<screen>&prompt.root;kadmin
> > +	kadmin> ext --keytab=/tmp/example.keytab host/myserver.smithclan.prv
> > +	kadmin> exit</screen>
> 
> The commands should be inside <userinput>.

Done my friend, thank you.

-- 
Tom Rhodes