Localized mirror names

[Simon L. Nielsen]

On 2003.11.22 21:53:45 +0900, Hiroki Sato wrote:
> Hi all,
> 
>  I made a new patchset to brush up mirrors.xml and resolve sort order
>  problem in localized documents.  In addition, to make mirrors.xml
>  usable from doc/ and www/, some structural changes are included.
>  The main components are:

In general it looks really good, but (of course :) ) I have some
comments:

In www/ja/includes.xsl you seem to have some commented out text that
looks leftover and could just be removed e.g.:

> +<!--
>    <xsl:variable name="u.rel.notes">
>      <xsl:value-of select="$base"/>/releases/<xsl:value-of select="$rel.current"/>R/relnotes.html</xsl:variable>
> +-->

In www/share/mk/web.site.mk:

> @@ -77,6 +77,31 @@
>  #
>  NO_SUBDIR=	YES
>  
> +#
> +# for dependency
> +#
> +
> +XML_NEWS=	${.CURDIR}/news/news.xml
> +XML_NEWS+=	${.CURDIR}/news/press.xml
> +XML_NEWS+=	${.CURDIR}/news/includes.xsl

Shouldn't theese also use WEB_PREFIX or some other prefix so it works in
other directories than www/<lang>/ ?  This is not too important though.

The doc/share/mk/doc.images.mk file has the A4 workaround, which should
probably be commited seperatly?

In README.mirrors the first two indented sections are indented with one
space, and the rest with two - I think all should just be indented with
two.

BTW, I think the text in README.mirrors would be a good candidate to be
moved into the FDP Primer at some point.

There seems to have slipped an extra close parenthesis in
doc/ja_JP.eucJP/share/sgml/transtable.xml :

> @@ -1,4 +1,18 @@
>  <?xml version="1.0" encoding="euc-jp"?>
> +<!-- $FreeBSD$ -->
> +
> +<!--
> +
> +  This is a translation table used in transtable-master.xsl.
> +  For example:
> +
> +  <word>
> +    <orig>word in English)</orig>
                            ^
> +    <tran>word in your language</tran>
> +  </word>
> +
> +-->

Typo :

> Index: doc/share/mk/doc.project.mk
> ===================================================================
> RCS file: /home/dcvs/doc/share/mk/doc.project.mk,v
> retrieving revision 1.15
> diff -d -u -I\$FreeBSD:.*\$ -I\$NetBSD:.*\$ -I\$OpenBSD:.*\$ -I\$Id:.*\$ -I\$hrs:.*\$ -r1.15 doc.project.mk
> --- doc/share/mk/doc.project.mk	1 Aug 2003 20:28:55 -0000	1.15
> +++ doc/share/mk/doc.project.mk	20 Nov 2003 05:03:35 -0000
> @@ -48,6 +48,9 @@
>  #	doc.subdir.mk	Subdirectory related configuration, including
>  #			handling "obj" builds.
>  #
> +# 	doc.commom.mk	targets and variables commonly used in doc/ and
                 ^ n
> +#			www/ tree.
> +#

There are some EOL whitespace in:  www/share/sgml/includes.header.xsl,
www/share/sgml/includes.release.xsl, doc/share/mk/doc.common.mk,
doc/share/sgml/README.mirrors, and doc/share/sgml/transtable-master.xsl.

I know some of the EOL whitepsace are just from text you have
copy/pasted, but now seem a good time to get rid of it, when it's being
moved anyway.

BTW. if you use emacs I would recomend using '(setq-default
show-trailing-whitespace t)' in your .emacs file.

>   doc/share/sgml/transtable-{local,master}.xsl
> 	translates .xml file using transtable.xml.
> 
>   doc/share/sgml/transtable.xml
> 	a translation table.

I must say that I really like the transtable - seams to be a neat way to
handle it :-).

>  Could anyone please try and/or review this?

Go for it!

The test builds I made all worked fine.

-- 
Simon L. Nielsen
FreeBSD Documentation Team
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-doc/attachments/20031123/cceac3a7/attachment.sig>