Did I get this right?

[Ceri Davies]

On Wed, Nov 12, 2003 at 09:53:35AM -0800, Wes Peters wrote:
> I added a section about CUPS, mostly cribbed from the pkg-descr, to the 
> handbook printing chapter.  I'm pretty fuzzy with doc tools and such, 
> and therefore need a thorough review.  Please have at me over the 
> attached diff, and thanks in advance.  ;^)

Hi Wes,

Thanks for knocking this together, but just to be cruel I'm going to
pick your patch apart - don't let it put you off ;-)

> RCS file: /home/dcvs/doc/en_US.ISO8859-1/books/handbook/printing/chapter.sgml,v
> retrieving revision 1.81
> diff -u -w -u -w -r1.81 chapter.sgml
> --- chapter.sgml	5 Nov 2003 10:36:55 -0000	1.81
> +++ chapter.sgml	12 Nov 2003 17:50:17 -0000
> @@ -4585,6 +4585,27 @@
>  	      url="http://www.lprng.org/"></ulink>.</para>
>  	</listitem>
>        </varlistentry>
> +      <varlistentry>
> +	<term>CUPS</term>
> +
> + 	<indexterm><primary>CUPS</primary></indexterm>	  
> +	<listitem>
> +	  <para><application>CUPS</application>, the Common UNIX Printing
> +	    System, provides a portable printing layer for UNIX-based
> +	    operating systems. It has been developed by Easy Software
                              ^
Two spaces here please.

> +	    Products to promote a standard printing solution for all UNIX
                                                                     ^^^^
&unix;

> +            vendors and users.</para>
              ^
One extra space here, please get rid.
There should also be a new line between this <para> and the next.

> +	  <para>CUPS uses the Internet Printing Protocol ("IPP") as the
                                                          ^^^^^
<acronym>IPP</acronym>

> +	    basis for managing print jobs and queues. The Line Printer
                                                     ^
Add another space (last time I'll mention this, but it goes for the next
occurrence too).

> +	    Daemon ("LPD") Server Message Block ("SMB"), and AppSocket
                    ^^^^^                        ^^^^^
<acronym>LPD</acronym>, <acronym>SMB</acronym>

> +	    (a.k.a. JetDirect) protocols are also supported with reduced
> +	    functionality. CUPS adds network printer browsing and
> +	    PostScript Printer Description ("PPD") based printing
                                            ^^^^^
<acronym>PPD</acronym>

> +	    options to support real-world printing under UNIX.</para>
                                                         ^^^^
&unix;

> +	  <para>The main site for <application>CUPS</application> is <ulink
> +	      url="http://www.cups.org/"></ulink>.</para>
            ^^
Two extra spaces here.

> +	</listitem>
> +      </varlistentry>
        ^
This whitespace looks funny, but I suspect you're just falling in line with
the rest of the file, in which case it's ok.

Thanks again,

Ceri

-- 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-doc/attachments/20031112/e7c64c5f/attachment.sig>