doc.common.mk 1.3

[Udo Erdelhoff]

Morning,
On Tue, Dec 30, 2003 at 07:45:07PM +0900, Hiroki Sato wrote:
>  I understand the problem.  As you pointed out, currently
>  if the pathname does not include "doc" or "www", LANGCODE and
>  WWW_LANGCODE are not defined properly. 

uh, no.  My point was that a pre-defined LANGCODE is OVERWRITTEN (with
a bad value) unless WWW_LANGCODE is not defined.  But this is only a
symptom of the real problem.

The underlying question is:  Why do I have to worry at all about www
while working on docs?  The bar for working on FreeBSD docs is already
quite high with all the programs you need.  Making it neccessary to
think about the www directories raises this bar even higher.

And "out-of-tree" builds are more than just substituing "/usr/www"
and "/usr/doc" with "/home/ue/www" and "/home/ue/doc", respectivly.
For example, everybody who works on more than one version of the
release notes (I currently track FIFTEEN versions of them, with
more to come) may very well have /usr/doc and /usr/www in their
usual places, plus a huge "out-of-tree" chunk consisting of the
various /usr/src/release/doc subtrees.  Or, to keep things limited
to doc/www, to have /usr/www and /usr/doc and their usual places
plus an extra for test builds of the web site.

I understand the need for some "guess-the-langcode-from-the-path"
logic in the current build infrastructure to handle "cd /usr/doc;make"
and stuff like that.  I am not happy with it (what's so bad about
adding LANGCODE?=<whatever> to each Makefile?), but that is another
matter.

In other words, your patch changes too much and introduces yet
another set of variables that developers have to think about.
And it links doc and www building together, allthough the two
should be separate, clearly violating POLA.

/s/Udo
-- 
"When faced with a choice between evils, I always pick the one I haven't
tried before." -- Mae West
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 305 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-doc/attachments/20031231/e19ee5c6/attachment.sig>