docs/60107: [PATCH] update sample code in PCI driver chapter of arch handbook
Lukas Ertl
l.ertl at univie.ac.at
Wed Dec 10 10:30:22 UTC 2003
The following reply was made to PR docs/60107; it has been noted by GNATS.
From: Lukas Ertl <l.ertl at univie.ac.at>
To: j.el-rayes at daemon.li
Cc: FreeBSD-gnats-submit at FreeBSD.org
Subject: Re: docs/60107: [PATCH] update sample code in PCI driver chapter of
arch handbook
Date: Wed, 10 Dec 2003 11:21:44 +0100 (CET)
On Wed, 10 Dec 2003, Josef El-Rayes wrote:
> Lukas Ertl <l.ertl at univie.ac.at> wrote:
> > +#include <sys/param.h> /* defines used in kernel.h */
> > -#include <sys/param.h> /* defines used in kernel.h */
>
> hi lukas!
>
> it is a good idea to have a look at the diff-generated patch
> before sending in, to avoid bogus lines like this.
It is a good idea to actually understand what the patch does before
calling it bogus.
The original code had sys/param.h and sys/types.h included, which is a
style(9) violation. My patch removes one include and moves the other one
further up.
regards,
le
--
Lukas Ertl eMail: l.ertl at univie.ac.at
UNIX Systemadministrator Tel.: (+43 1) 4277-14073
Vienna University Computer Center Fax.: (+43 1) 4277-9140
University of Vienna http://mailbox.univie.ac.at/~le/
More information about the freebsd-doc
mailing list