Review of porters-handbook changes

[Joe Marcus Clarke]

On Mon, 2003-08-18 at 08:53, Simon L. Nielsen wrote:
> On 2003.08.17 10:47:18 -0400, Joe Marcus Clarke wrote:
> > On Sun, 2003-08-17 at 07:07, Simon L. Nielsen wrote:
> > > On 2003.08.16 17:28:19 -0400, Joe Marcus Clarke wrote:
> > > > Can someone review the attached diff to the porter's handbook?  It was
> > > > submitted by Sergey Matveychuk <sem at ciam.ru> for some of the recent
> > > > ports infrastructure changes.  It is technically accurate, and I fixed a
> > > > few grammar and spelling nits, but I would like a doc committers take on
> > > > it before committing.  Also, if one of you would rather commit, that's
> > > > fine.  Thanks!
> > > 
> > > There are some places where 8 spaces have been used instead of a tab
> > > (can be fixed by marking the regions and using 'meta-x tabify' in
> > > emacs').  There are also some end of line white-spaces which should be
> > > removed.
> > 
> > I tried to preserve the style of adjacent blocks.  To that end, some use
> > spaces, so I opted for spaces to keep things lined up.
> 
> OK, I didn't check the rest for the file for style, and the tab/space
> thing is not that important then.
> 
> But the end of line whitespace still doesn't need to be there :).  It's
> not crucial to remove it, but there is no reason to have it there.
> 
> Sorry for being so pedantic about this...
> 
> I have attached a patch where I have removed the end of line whitespace,
> and changed the pkg_deinstall reference (see below).
> 
> > --- doc/en_US.ISO8859-1/books/porters-handbook/book.sgml	17 Aug 2003 09:12:05 -0000	1.320
> > +++ doc/en_US.ISO8859-1/books/porters-handbook/book.sgml	17 Aug 2003 14:46:25 -0000
> > @@ -4316,6 +4086,19 @@
> >          </note>
> >        </sect1>
> >  
> > +      <sect1 id="pkg-deinstall">
> > +        <title><filename>pkg-deinstall</filename></title>
> > +
> > +        <para>This script executes when a package is removed.</para>
> > +
> > +        <para>
> > +          This script will be run twice by <command>pkg_delete</command>.
> 
> It's better to use "&man.pkg.delete.1;" instead of the command tag since
> it will create a link to the manual page.

Thanks!  Committed with your suggestions after doing a full make of
doc/.

Joe

-- 
Joe Marcus Clarke
FreeBSD GNOME Team	::	marcus at FreeBSD.org
gnome at FreeBSD.org
FreeNode / #freebsd-gnome
http://www.FreeBSD.org/gnome

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 187 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freebsd.org/pipermail/freebsd-doc/attachments/20030818/575c6a39/attachment.sig>