Review of porters-handbook changes

[Simon L. Nielsen]

On 2003.08.16 17:28:19 -0400, Joe Marcus Clarke wrote:
> Can someone review the attached diff to the porter's handbook?  It was
> submitted by Sergey Matveychuk <sem at ciam.ru> for some of the recent
> ports infrastructure changes.  It is technically accurate, and I fixed a
> few grammar and spelling nits, but I would like a doc committers take on
> it before committing.  Also, if one of you would rather commit, that's
> fine.  Thanks!

There are some places where 8 spaces have been used instead of a tab
(can be fixed by marking the regions and using 'meta-x tabify' in
emacs').  There are also some end of line white-spaces which should be
removed.

> --- doc/en_US.ISO8859-1/books/porters-handbook/book.sgml	10 Aug 2003 20:34:31 -0000	1.319
> +++ doc/en_US.ISO8859-1/books/porters-handbook/book.sgml	16 Aug 2003 21:24:46 -0000

> @@ -3216,11 +3227,23 @@
>  
>  	      <entry>Says that the port uses Perl 5 to build and run.</entry>
>  	    </row>
> -	    
> +
>  	    <row>
> -	      <entry><makevar>PERL</makevar></entry>
> +	      <entry><makevar>PERL_CONFIGURE</makevar></entry>
> +
> +	      <entry>Configure using Perl's MakeMaker.  It implies USE_PERL5.</entry>
                                                                   ^^^^^^^^^
Missing makevar tag.

> @@ -4316,6 +4083,19 @@
>          </note>
>        </sect1>
>  
> +      <sect1 id="pkg-deinstall">
> +        <title><filename>pkg-deinstall</filename></title>
> +
> +        <para>This script executes when a package is removed.</para>
> +
> +	<para>
> +	  Like the <filename>pkg-install</filename> script it will be run twice.
> +	  The first time as <literal>${SH} pkg-install ${PKGNAME}
> +	  DEINSTALL</literal> and the second time as
> +	  <literal>${SH} pkg-install ${PKGNAME} POST-DEINSTALL</literal>.
> +	</para>

Perhaps a reference to pkg_delete(1) ?

Otherwise it looks OK to me, but I have only checked the markup, not the
language.

-- 
Simon L. Nielsen
FreeBSD Documentation Team
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-doc/attachments/20030817/c8a1683d/attachment.sig>