Possible bug in revision link generation in human readable
diff mode
VilleSkyttä
scop at FreeBSD.org
Wed Nov 17 21:03:23 GMT 2004
On Tue, 2004-11-16 at 23:24, Michael Sims wrote:
> It looks like there may be a bug in the way CVSweb generates links to specific
> revisions when showing a human-readable, or colored diff (f=h). This problem
> appears in the latest cvsweb Debian package (3.0.2-1 in "testing") and also in the
> latest available from the CVSweb site (3.0.4). When viewing a colored diff between
> two revisions in "Show all branches" mode, the various links to specific revisions
> lack the question mark delimiter between the file path and the query string. For
> example, a link such as this may be generated:
>
> http://host/cgi-bin/cvsweb/module/file.php;rev=1.15
Right. I was able to reproduce this by setting the default diff format
to "h" in cvsweb.conf; couldn't reproduce if it was "u". Nevertheless,
it's a bug, and your fix is correct. I'll commit a slightly modified
one in a jiffy, it'll be included in the next cvsweb version. Thanks!
More information about the freebsd-cvsweb
mailing list