diff crashes under mod_perl

[Brian Cassidy]

Hi Ville,

Thanks for responding.

Ville Skyttä wrote:

> On Fri, 2003-12-12 at 00:52, Brian Cassidy wrote:
> 
> 
>>I'm using the most recent cvsweb beta. Apache 2.0.48. perl 5.8.0. 
>>mod_perl 1.99_10.
> 
> 
> Hm, I have the same setup, except Perl 5.8.1 and mod_perl 1.99_09.

Before i say anything about what you've said below, I decided to upgrade 
my mod_perl installation to 1.99_12 (released today). That appears to 
have cleared my problems. Diffs work as advertised.

>>Viewing a diff produces the following entry in the apache error_log:
> 
> 
> Did the diff still appear correctly in the browser?
> 

Nope.

>>[Thu Dec 11 18:52:53 2003] [error] 14871: ModPerl::Registry: $r wasn't 
>>passed at /home/httpd/cvs/cvs.cgi line 2238.
> 
> 
> I cannot reproduce that.  Line 2238 in 2.9.1 contains
> "openOutputFilter()", which should be a no-op unless you have
> $output_filter defined in cvsweb.conf.  I couldn't reproduce the error
> even when setting up a trivial output filter like
> 
>   $output_filter= '/usr/bin/tr "[a-zA-Z]" "_"';
> 
> Could you check if you have $output_filter set and if you need it, and
> whether disabling it affects this?  I'll try to upgrade my mod_perl
> soonish...

I first tried that output filter from your email without success. I then 
went on to upgrade mod_perl and all was well. I guess I'll chalk that up 
to a bug in that version of mod_perl.

Thanks,

-Brian