On 14-CURRENT: no ports options anymore?

[Jamie Landeg-Jones]

"Hartmann, O." <o.hartmann at walstatt.org> wrote:

> On Sat, 13 Mar 2021 15:13:15 -0500
> Michael Butler via freebsd-current <freebsd-current at freebsd.org> wrote:
>
> > On 3/13/21 3:00 PM, Hartmann, O. wrote:
> > > On Sat, 13 Mar 2021 19:52:47 +0000 (UTC)
> > > Filippo Moretti via freebsd-current <freebsd-current at freebsd.org> wrote:
> > >   
> > >>   
> > >> I had the same problem in console modeFiippo
> > >>      On Saturday, March 13, 2021, 8:33:57 PM GMT+1, Stefan Esser <se at freebsd.org>
> > >> wrote:
> > >>
> > >>   Am 13.03.21 um 20:17 schrieb Hartmann, O.:  
> > >>> Since I moved on to 14-CURRENT, I face a very strange behaviour when trying to set
> > >>> options via "make config" or via poudriere accordingly. I always get "===> Options
> > >>> unchanged" (when options has been already set and I'd expect a dialog menu).
> > >>> This misbehaviour is throughout ALL 14-CURRENT systems (the oldest is at FreeBSD
> > >>> 14.0-CURRENT #49 main-n245422-cecfaf9bede9: Fri Mar 12 16:08:09 CET 2021 amd64).
> > 
> > I ran into something similar where dialog4ports would dump core after an 
> > upgrade. Rebuilding the port (ports-mgmt/dialog4ports) solved it for me,
> > 
> > 	imb
>
> Thanks, recompilig ports-mgmt/dialog4ports solved the problem! I was sure that after some
> ncurses changes in 14-CURRENT I've rebuilt every single port on all 14-CURRENT systems
> after that incident, bad luck.

This bit me a few years ago - in my case, the terminal type wasn't recognised. If dialog4ports
doesn't run successfully, the error is ignored by the ports scripts. This was on a new
install (hence the reason I hadn't yet installed my termcap), and it meant that before I
noticed, quite a number of ports got installed without the options I wanted.

Since then, I've patched bsd.port.mk with:

--- bsd.port.mk.orig    2017-06-06 17:38:00.000000000 +0100
+++ bsd.port.mk 2017-06-08 01:31:36.320294000 +0100
@@ -4729,8 +4729,8 @@
        trap "${RM} $${TMPOPTIONSFILE}; exit 1" 1 2 3 5 10 13 15; \
        ${SETENV} ${D4P_ENV} ${SH} ${SCRIPTSDIR}/dialog4ports.sh $${TMPOPTIONSFILE} || { \
                ${RM} $${TMPOPTIONSFILE}; \
-               ${ECHO_MSG} "===> Options unchanged"; \
-               exit 0; \
+               ${ECHO_MSG} "===> ERROR: Options unchanged"; \
+               exit 1; \
        }; \
        ${ECHO_CMD}; \
        if [ ! -e $${TMPOPTIONSFILE} ]; then \

I never submitted this patch, because the way it was written seemed intentional. Maybe this should be reviewed?

Cheers,
  Jamie