svn commit: r365419 - in head/sys/dev: ath bwi iwm iwn mwl otus usb/wlan wtap

[Tomoaki AOKI]

On Fri, 11 Sep 2020 14:20:22 +0000
"Bjoern A. Zeeb" <bz at FreeBSD.org> wrote:

> On 11 Sep 2020, at 14:02, Tomoaki AOKI wrote:
> 
> > On Thu, 10 Sep 2020 10:22:05 +0000
> > "Bjoern A. Zeeb" <bz at FreeBSD.org> wrote:
> >
> >> On 9 Sep 2020, at 22:41, Tomoaki AOKI wrote:
> >>
> >>> This breaks at least iwm. (Other drivers not tested.)
> >>>
> >>> Messages below are repeatedly shown and no carrier detected.
> >>> Manually reverting this commit fixes the issue.
> >>>
> >>> iwm0: failed to send antennas before calibration: 35
> >>> iwm_run_init_ucode: failed 35
> >>> iwm_init_hw failed 35
> >>> iwm0: could not initiate scan
> >>>
> >>>
> >>> and lesser times messages below.
> >>>
> >>> iwm0: iwm_send_phy_db_data: Cannot send HCMD of Phy DB cfg section, 
> >>> 35
> >>> iwm_init_hw failed 35
> >>> iwm0: could not initiate scan
> >>>
> >>
> >>
> >> I’ll try to test iwm as well, in case you are faster, can you 
> >> please
> >> try this instead of reverting;  the previous version never made it 
> >> past
> >> the first return anymore in the last years it seems, so we can remove
> >> the function entirely to keep the status quo:
> >>
> >> Sorry for the oversight.
> >
> > Your patch (needed to fix some line wrapping, though) fixed the issue
> > for me. Thanks!
> 
> Committed in r365633 in HEAD.   stable/12 already has the fix (#if 0ed 
> the code).
> I’ll merged the change in 3 days to keep the code in sync.
> 
> 
> Thanks a lot for reporting and testing!
> 
> Bjoern

Confirmed. Thanks!


> _______________________________________________
> freebsd-current at freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-unsubscribe at freebsd.org"
> 


-- 
Tomoaki AOKI    <junchoon at dec.sakura.ne.jp>