Build failed compiling ittnotify_static.pico

[Mark Millard]

Bob Willcox bob at immure.com wrote on
Fri Mar 13 21:08:16 UTC 2020 :

> My 13.0-current system (just updated about 2 hours ago) that is failing with this
> error when trying to do a 'make makeworld'
> 
> --- ittnotify_static.pico ---
> cc -target x86_64-unknown-freebsd13.0 --sysroot=/usr/obj/usr/src/amd64.amd64/tmp -B/usr/obj/usr/src/amd64.amd64/tmp/usr/bin -fpic -DPIC  -O2 -pipe   -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/usr/src/lib/libomp -I/usr/src/contrib/llvm-project/openmp/runtime/src -I/usr/src/contrib/llvm-project/openmp/runtime/src/thirdparty/ittnotify -ffunction-sections -fdata-sections -g -MD  -MF.depend.ittnotify_static.pico -MTittnotify_static.pico -std=gnu99 -Wno-format-zero-length -fstack-protector-strong -Wno-atomic-alignment -Wsystem-headers -Werror -Wno-pointer-sign -Wno-empty-body -Wno-string-plus-int -Wno-unused-const-variable -Wno-tautological-compare -Wno-unused-value -Wno-parentheses-equality -Wno-unused-function -Wno-enum-conversion -Wno-unused-local-typedef -Wno-address-of-packed-member -Wno-switch -Wno-switch-enum -Wno-knr-promoted-parameter -Wno-parentheses  -Qunused-arguments    -c /usr/src/contrib/llvm-project/openmp/runtime/src/thirdparty/ittnotify/ittnotify_static.c -o ittnotify_static.pico
> cc: error: no such file or directory: '/usr/src/contrib/llvm-project/openmp/runtime/src/thirdparty/ittnotify/ittnotify_static.c'
> cc: error: no input files
> *** [ittnotify_static.pico] Error code 1
> 
> 
> Anyone else seeing this? Any suggestions for a fix?


The problem introduced in head -r358851 was supposed
to be fixed by head -r358907:

QUOTE

Dimitry Andric dim at FreeBSD.org 
Thu Mar 12 11:39:07 UTC 2020
	• Previous message (by thread): svn commit: r358906 - head/stand/i386/libi386
	• Next message (by thread): svn commit: r358908 - in head/sys: conf modules powerpc/conf
	• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Author: dim
Date: Thu Mar 12 11:39:04 2020
New Revision: 358907
URL: 
https://svnweb.freebsd.org/changeset/base/358907


Log:
  Allow -DNO_CLEAN build across r358851.
  
  The openmp 10.0.0 import renamed one .c file to .cpp, and this is
  something our dependency system does not handle correctly.  Add another
  ad-hoc cleanup to get rid of the stale dependency.
  
  PR:		244251
  MFC after:	6 weeks
  X-MFC-With:	358851

Modified:
  head/Makefile.inc1

Modified: head/Makefile.inc1
==============================================================================
--- head/Makefile.inc1	Thu Mar 12 06:45:08 2020	(r358906)
+++ head/Makefile.inc1	Thu Mar 12 11:39:04 2020	(r358907)
@@ -924,6 +924,15 @@ _sanity_check: .PHONY .MAKE
 _cleanobj_fast_depend_hack: .PHONY
 # Syscall stubs rewritten in C and obsolete MD assembly implementations
 # Date      SVN Rev  Syscalls/Changes
+# 20200310  r358851  rename of openmp's ittnotify_static.c to .cpp
+.for f in ittnotify_static
+	@if [ -e "${OBJTOP}/lib/libomp/.depend.${f}.pico" ] && \
+	    egrep -qw '${f}\.c' ${OBJTOP}/lib/libomp/.depend.${f}.pico; then \
+		echo "Removing stale dependencies for ${f}"; \
+		rm -f ${OBJTOP}/lib/libomp/.depend.${f}.* \
+		   ${LIBCOMPAT:D${LIBCOMPAT_OBJTOP}/lib/libomp/.depend.${f}.*}; \
+	fi
+.endfor
 # 20191009  r353340  removal of opensolaris_atomic.S (also r353381)
 .if ${MACHINE} != i386
 .for f in opensolaris_atomic

END QUOTE

I've not upgraded to a lvm10 based vintage yet. I found
the above while looking into if updating looked reasonable.
So I've no direct evidence of if the change served its
purpose or not.

But it does suggest that removing any stale files
from the build area that have names matching:

.depend.ittnotify_static.*

is supposed to be sufficient to get rid of old
ittnotify_static.c file references for the following
build attempts.

It looks like two separate lib/libomp/ areas may have
such files.

===
Mark Millard
marklmi at yahoo.com
( dsl-only.net went
away in early 2018-Mar)