review request: loader: implement framebuffer console

Mon Dec 14 14:03:31 UTC 2020

Jan Beich <jbeich at FreeBSD.org> writes:

> Toomas Soome <tsoome at me.com> writes:
>
>> hi!
>>
>> I have been working on proper framebuffer support on FreeBSD loader
>> and there is the current state: https://reviews.freebsd.org/D27420
>> <https://reviews.freebsd.org/D27420>
>>
>> All feedback is welcome, and especially if you can spare some time for testing:)
>
> Do you have another source? Phabricator excludes some files e.g.,
>
>   $ fetch 'https://reviews.freebsd.org/D27420?download=true' | patch -Efsp0
>   $ make -sj8 buildworld
>   [...]
>   ===> stand/images (all)
>   make[4]: make[4]: don't know how to make freebsd-brand-rev.png. Stop

FWIW, I've tried CLI but no joy:

  $ svn status
  $ pkg install arcanist-php80
  $ arc patch D27420
  PHP Deprecated:  Function libxml_disable_entity_loader() is deprecated in /usr/local/lib/php/arcanist/support/init/init-script.php on line 92

  Deprecated: Function libxml_disable_entity_loader() is deprecated in /usr/local/lib/php/arcanist/support/init/init-script.php on line 92
  [2020-12-14 13:42:12] EXCEPTION: (Exception) Error while loading file "/usr/local/lib/php/arcanist/src/workflow/ArcanistWorkflow.php": Private methods cannot be final as they are never overridden by other classes at [<arcanist>/src/init/lib/PhutilBootloader.php:275]
  arcanist()
    #0 PhutilBootloader::executeInclude(string) called at [<arcanist>/src/init/lib/PhutilBootloader.php:207]
    #1 PhutilBootloader::loadLibrarySource(string, string) called at [<arcanist>/src/symbols/PhutilSymbolLoader.php:422]
    #2 PhutilSymbolLoader::loadSymbol(array) called at [<arcanist>/src/symbols/PhutilSymbolLoader.php:277]
    #3 PhutilSymbolLoader::selectAndLoadSymbols() called at [<arcanist>/src/init/init-library.php:23]
    #4 __phutil_autoload(string)
    #5 class_exists(string) called at [<arcanist>/src/symbols/PhutilClassMapQuery.php:216]
    #6 PhutilClassMapQuery::loadMap() called at [<arcanist>/src/symbols/PhutilClassMapQuery.php:184]
    #7 PhutilClassMapQuery::execute() called at [<arcanist>/src/runtime/ArcanistRuntime.php:535]
    #8 ArcanistRuntime::newWorkflows(ArcanistArcToolset) called at [<arcanist>/src/runtime/ArcanistRuntime.php:115]
    #9 ArcanistRuntime::executeCore(array) called at [<arcanist>/src/runtime/ArcanistRuntime.php:37]
    #10 ArcanistRuntime::execute(array) called at [<arcanist>/support/init/init-arcanist.php:6]
    #11 require_once(string) called at [<arcanist>/bin/arc:10]

  $ svn status
  $ pkg install arcanist-php74
  $ arc patch D27420
  [...]
  A  (bin)  stand/images/freebsd-logo-rev.png
  A  (bin)  stand/images/freebsd-brand.png
  A  (bin)  stand/images/freebsd-brand-rev.png
  A         stand/images/Makefile
  svn: warning: W150002: 'stand/images' is already under version control
  svn: E200009: Could not add all targets because some targets are already versioned
  svn: E200009: Illegal target for the requested operation
  A         stand/i386/libi386/vbe.h
  A         stand/i386/libi386/vbe.c
  A         stand/fonts/Makefile
  A         stand/fonts/INDEX.fonts
  svn: warning: W150002: 'stand/fonts' is already under version control
  svn: E200009: Could not add all targets because some targets are already versioned
  svn: E200009: Illegal target for the requested operation
  A         stand/common/gfx_fb.h
  A         stand/common/gfx_fb.c
  A         contrib/terminus/ter-u32n.bdf
  A         contrib/terminus/ter-u32b.bdf
  A         contrib/terminus/ter-u28n.bdf
  A         contrib/terminus/ter-u28b.bdf
  A         contrib/terminus/ter-u24n.bdf
  A         contrib/terminus/ter-u24b.bdf
  A         contrib/terminus/ter-u22n.bdf
  A         contrib/terminus/ter-u22b.bdf
  A         contrib/terminus/ter-u20n.bdf
  A         contrib/terminus/ter-u20b.bdf
  A         contrib/terminus/ter-u18n.bdf
  A         contrib/terminus/ter-u18b.bdf
  A         contrib/terminus/ter-u16v.bdf
  A         contrib/terminus/ter-u16n.bdf
  A         contrib/terminus/ter-u16b.bdf
  A         contrib/terminus/ter-u14v.bdf
  A         contrib/terminus/ter-u14n.bdf
  A         contrib/terminus/ter-u14b.bdf
  A         contrib/terminus/ter-u12n.bdf
  A         contrib/terminus/ter-u12b.bdf
  svn: warning: W150002: 'contrib/terminus' is already under version control
  svn: E200009: Could not add all targets because some targets are already versioned
  svn: E200009: Illegal target for the requested operation
  A         contrib/pnglite/pnglite.h
  A         contrib/pnglite/pnglite.c
  A         contrib/pnglite/README.md
  A         contrib/pnglite/LICENSE
  svn: warning: W150002: 'contrib/pnglite' is already under version control
  svn: E200009: Could not add all targets because some targets are already versioned
  svn: E200009: Illegal target for the requested operation
  svn: E125004: MIME type 'application/octet-stream
  \ No newline at end of property' contains invalid character '
  ' in media type
  svn: E125004: MIME type 'application/octet-stream
  \ No newline at end of property' contains invalid character '
  ' in media type
  svn: E125004: MIME type 'application/octet-stream
  \ No newline at end of property' contains invalid character '
  ' in media type
  svn: E135001: Unrecognized line ending style 'native
  \ No newline at end of property' for 'stand/images/Makefile'
  property 'svn:keywords' set on 'stand/images/Makefile'
  svn: E125004: MIME type 'text/plain
  \ No newline at end of property' contains invalid character '
  ' in media type
  svn: E135001: Unrecognized line ending style 'native
  \ No newline at end of property' for 'stand/i386/libi386/vbe.h'
  property 'svn:keywords' set on 'stand/i386/libi386/vbe.h'
  svn: E125004: MIME type 'text/plain
  \ No newline at end of property' contains invalid character '
  ' in media type
  svn: E135001: Unrecognized line ending style 'native
  \ No newline at end of property' for 'stand/i386/libi386/vbe.c'
  property 'svn:keywords' set on 'stand/i386/libi386/vbe.c'
  svn: E125004: MIME type 'text/plain
  \ No newline at end of property' contains invalid character '
  ' in media type
  svn: E135001: Unrecognized line ending style 'native
  \ No newline at end of property' for 'stand/fonts/Makefile'
  property 'svn:keywords' set on 'stand/fonts/Makefile'
  svn: E125004: MIME type 'text/plain
  \ No newline at end of property' contains invalid character '
  ' in media type
  svn: E135001: Unrecognized line ending style 'native
  \ No newline at end of property' for 'stand/common/gfx_fb.h'
  property 'svn:keywords' set on 'stand/common/gfx_fb.h'
  svn: E125004: MIME type 'text/plain
  \ No newline at end of property' contains invalid character '
  ' in media type
  svn: E135001: Unrecognized line ending style 'native
  \ No newline at end of property' for 'stand/common/gfx_fb.c'
  property 'svn:keywords' set on 'stand/common/gfx_fb.c'
  svn: E125004: MIME type 'text/plain
  \ No newline at end of property' contains invalid character '
  ' in media type
  svn: E135001: Unrecognized line ending style 'native
  \ No newline at end of property' for 'contrib/pnglite/pnglite.h'
  property 'svn:keywords' set on 'contrib/pnglite/pnglite.h'
  svn: E125004: MIME type 'text/plain
  \ No newline at end of property' contains invalid character '
  ' in media type
  svn: E135001: Unrecognized line ending style 'native
  \ No newline at end of property' for 'contrib/pnglite/pnglite.c'
  property 'svn:keywords' set on 'contrib/pnglite/pnglite.c'
  svn: E125004: MIME type 'text/plain
  \ No newline at end of property' contains invalid character '
  ' in media type
   OKAY  Successfully applied patch to the working copy.

  $ ls -l stand/images/*.png
  -rw-r--r--  1 foo  foo  0 14 Dec 13:46 stand/images/freebsd-brand-rev.png
  -rw-r--r--  1 foo  foo  0 14 Dec 13:46 stand/images/freebsd-brand.png
  -rw-r--r--  1 foo  foo  0 14 Dec 13:46 stand/images/freebsd-logo-rev.png