UEFI boot broken in 13?

[Warner Losh]

On Tue, Jun 4, 2019 at 8:16 AM Warner Losh <imp at bsdimp.com> wrote:

>
>
> On Tue, Jun 4, 2019 at 7:11 AM Tomoaki AOKI <junchoon at dec.sakura.ne.jp>
> wrote:
>
>> Hi.
>>
>> Try attached patch for stand/efi/boot1/boot1.c.
>> This partially reverts r347193 and works at least for me.
>>
>> Without this, boot1.efi (bootx64.efi) forcibly boot from
>> first physical HDD/SSD, even if forcibly booted from other
>> physical drive via BIOS (UEFI firmware) menu.
>>
>> Remaining parts of
>> https://reviews.freebsd.org/D20513https://reviews.freebsd.org/D20513 and
>> following some commits does not
>> affect.
>>
>>  *Hand-crafted reverse patch from commit mail [1].
>>   Reverting whole r347193 is fine, too.
>>
>> [1]
>> https://lists.freebsd.org/pipermail/svn-src-head/2019-May/124677.html
>
>
> I'll take a look. My experience is that even prior to this patch, forcibly
> booting also failed though due to ordering issues...
>

More testing reveals that the issues prior to r347193 turned out to be
different, and r347193 really did break things. I've opted to fix this in a
slightly different way:

https://reviews.freebsd.org/D20513

Aoki-san, can you please check to see if the above review fixes things for
you as well? Thanks!

Warner