[CFT][patch] mandoc: don't segfault on empty tbl(1) continuation blocks

Baptiste Daroussin bapt at FreeBSD.org
Wed Jul 17 07:12:03 UTC 2019


On Tue, Jul 16, 2019 at 10:31:24PM +0300, Eygene Ryabinkin wrote:
> Good day.
> 
> Attached is the patch that makes built-in tbl(1) processor in mandoc
> to avoid dumping core when it renders the table with empty "T{ T}"
> block and horizontally-ruled table.
> 
> The simplest way to reproduce the issue is to either
>  - run 'man notmuch-config' with mail/notmuch installed;
>  - run 'mandoc tests/empty-table-cdata.1' against the attached
>    test-only manpage.
> 
> With the patch applied, one can utilize 'make check': regression
> test was added.  Perhaps an invocation of
> {{{
> mtree -deU -f /usr/src/etc/mtree/BSD.tests.dist -p /usr/tests
> }}}
> will be needed to run 'make check' without remaking/installing
> the world.
> 
> The patch is for the fresh -CURRENT.  Be interested in any results
> of its application and usage.
> 
> Thanks!
> 
> P.S.: please, CC me: I am not subscribed to the list.
> -- 
> Eygene Ryabinkin                                        ,,,^..^,,,
> [ Life's unfair - but root password helps!           | codelabs.ru ]
> [ 82FE 06BC D497 C0DE 49EC  4FF0 16AF 9EAE 8152 ECFB | freebsd.org ]

Hello,

Thank you for the patch! Have it been discussed with upstream? I kind of remind
something like this being reported to upstream, but I haven't checked the
status.

Best regards,
Bapt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-current/attachments/20190717/ee5ed9bf/attachment.sig>


More information about the freebsd-current mailing list