problem building dev/e1000

[Ian Lepore]

On Fri, 2019-02-15 at 12:32 -0700, Warner Losh wrote:
> On Fri, Feb 15, 2019 at 12:17 PM Ian Lepore <ian at freebsd.org> wrote:
> 
> > On Fri, 2019-02-15 at 10:53 -0800, Enji Cooper wrote:
> > > > [...]
> > > 
> > > HO Eric!
> > > 
> > > iflib was a recently added requirement on stable/12 IIRC..?
> > > 
> > > Does the manpage note this dependency, and is there an UPDATING
> > > entry
> > > for this change?
> > > 
> > > Thanks!
> > > -Enji
> > > 
> > 
> > My question would be: why? If some drivers have a new dependency on
> > iflib, why isn't that expressed in sys/conf/files and handled
> > automatically?
> > 
> 
> Right now we have
> 
>  files:net/iflib.c optional ether pci iflib
> 
> in the files file. This would need to change to
> 
> files:net/iflib.c optional ether pci (em | igb | ...)
> 
> but we don't have a () operator in config. Or we'd need dozens of
> lines,
> and the duplicate elimination code in config has been tricky (though
> I
> didn't check it just now).
> 
> Warner
> 

I guess the question would be how many things does '...' represent now
and in the future?  What it would need to be, given our current
inflexible config(8) is

 net/iflib.c optional ether pci em | ether pci igb | ...

So if ... is 2 or 3 more drivers, that's not so bad.  If iflib is
eventually going to be used by dozens of drivers, even the parens would
make for a pretty ugly solution.

-- Ian