SVN r351457 breaks drm-current

[Konstantin Belousov]

On Sat, Aug 24, 2019 at 11:02:20AM -0600, Warner Losh wrote:
> forward declaring struct pcpu; in md_var.h "fixes" this, but I'm not sure
> that's the right fix.
More correct way to fix it is to include sys/pcpu.h before machine/md_var.h,
same as all in-tree consumers of the header do, apparently.

But another question is why the driver needs md_var.h, there are no
externally usable definitions there.

> 
> Warner
> 
> On Sat, Aug 24, 2019 at 10:35 AM Michael Butler <imb at protected-networks.net>
> wrote:
> 
> > As follows ..
> >
> > Building
> >
> > /usr/obj/usr/src/amd64.amd64/sys/TOSHI/modules/usr/local/sys/modules/drm-current-kmod/linuxkpi/linux_compat.o
> > --- linux_compat.o ---
> > In file included from
> >
> > /usr/local/sys/modules/drm-current-kmod/linuxkpi/gplv2/src/linux_compat.c:5:
> > ./machine/md_var.h:61:34: error: declaration of 'struct pcpu' will not
> > be visible outside of this function [-Werror,-Wvisibility]
> > void    amd64_bsp_pcpu_init1(struct pcpu *pc);
> >                                     ^
> > ./machine/md_var.h:63:32: error: declaration of 'struct pcpu' will not
> > be visible outside of this function [-Werror,-Wvisibility]
> > void    amd64_bsp_ist_init(struct pcpu *pc);
> >                                   ^
> >
> >         imb
> > _______________________________________________
> > freebsd-current at freebsd.org mailing list
> > https://lists.freebsd.org/mailman/listinfo/freebsd-current
> > To unsubscribe, send any mail to "freebsd-current-unsubscribe at freebsd.org"
> >