Proper way to remove never used ioctls

[Vladimir Kondratyev]

On 2018-06-02 20:36, Allan Jude wrote:
> On 2018-06-02 11:03, Warner Losh wrote:
>> On Sat, Jun 2, 2018 at 7:33 AM, Vladimir Kondratyev 
>> <vladimir at kondratyev.su>
>> wrote:
>> 
>>> Hi,
>>> 
>>> Our sys/mouse.h header has a definition of MOUSE_GETVARS and 
>>> MOUSE_SETVARS
>>> ioctls which are not documented and only stubbed in a few drivers: 
>>> mse(4),
>>> psm(4) and syscon's sysmouse(4). The only exception is MOUSE_GETVARS
>>> implemented in psm(4)
>>> 
>>> Given the fact that they were introduced 20 years ago, implementation 
>>> was
>>> never completed and googling on them shows no traces of usage in 
>>> indexed
>>> universe, is it acceptable to just drop both defines and 
>>> implementation
>>> w.o. leaving any COMPAT_FREEBSD shims?
>> 
>> 
>> I'd prepare a patch just removing them. I'd then send that patch to 
>> the
>> ports mgr team and request a exp-run. Details for that can be found in
>> https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/ports.html
>> 
>> Once that's done, submit a Phabricator review and send me email. I'll 
>> make
>> sure it gets pushed in if there's no objections.
>> 
>> Warner
> 
> This indeed seems to be the correct approach. The exp-run will compile
> the entire ports tree against the patched base system, and identify any
> 3rd party software that fails to compile because of the change.

Thank you, Allan and Warner! I'll follow yours advice.

-- 
WBR
Vladimir Kondratyev