Error compiling isboot-kmod

[Ian Lepore]

On Fri, 2018-01-26 at 23:20 -0700, John Nielsen wrote:
> > 
> > On Jan 26, 2018, at 9:42 PM, John Nielsen <lists at jnielsen.net> wrote:
> > 
> > > 
> > > [...]
> > --- iscsi.o ---
> > iscsi.c:1146:3: error: incompatible pointer types passing 'void (struct mbuf *, void *, void *)' to parameter of type 'm_ext_free_t *' (aka 'void (*)(struct mbuf *)') [-Werror,-Wincompatible-pointer-types]
> >                MEXTADD(md, (caddr_t)ds_dd, (ISCSI_ALIGN(pp->ds_len)
> >                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > /usr/src/sys/sys/mbuf.h:887:42: note: expanded from macro 'MEXTADD'
> >    m_extadd((m), (char *)(buf), (size), (free), (arg1), (arg2),        \
> >                                         ^~~~~~
> > /usr/src/sys/sys/mbuf.h:634:59: note: passing argument to parameter here
> > void             m_extadd(struct mbuf *, char *, u_int, m_ext_free_t,
> Looks like iscsi.c needs to be fixed up following r324446
> (https://svnweb.freebsd.org/changeset/base/324446). Starting to be
> out of my depth unless there's a mechanical way to make the changes?
> 
> 

I'm not set up to test-compile this against -current right now, so I'm
not sure if this is all that remains or just another breadcrumb on the
trail, but... try the attached patch.

-- Ian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: iscsi_mbuf_free.diff
Type: text/x-patch
Size: 678 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-current/attachments/20180127/ad5a6927/attachment.bin>