Fatal trap 12 booting FreeBSD-CURRENT via isboot kernel module.

[John Nielsen]

> On Feb 7, 2018, at 6:07 AM, Maurizio Vairani <maurizio1018 at gmail.com> wrote:
> 
> 2018-02-06 23:02 GMT+01:00 John Nielsen <lists at jnielsen.net>:
> > On Feb 6, 2018, at 11:50 AM, Ian Lepore <ian at FreeBSD.org> wrote:
> >
> > On Tue, 2018-02-06 at 11:33 -0700, John Nielsen wrote:
> >>
> >> Apparently sending a NULL socket pointer to ifioctl hasn't worked
> >> since this commit in 2011:
> >> https://svnweb.freebsd.org/base?view=revision&revision=218757
> >>
> >> So I'm going to add this patch to the port unconditionally once it
> >> works.
> >>
> >> Unfortunately, I can't compile the port with either my patch below or
> >> your original replacement version of isboot_ifup(). :( Did you make
> >> other changes? Here's the error I'm getting:
> >>
> >> --- isboot.o ---
> >> isboot.c:425:53: error: incomplete definition of type 'struct thread'
> >>     error = socreate(AF_INET, &so, SOCK_DGRAM, 0, td->td_ucred, td);
> >>                                                   ~~^
> >> /usr/src/sys/sys/systm.h:185:8: note: forward declaration of 'struct
> >> thread'
> >> struct thread;
> >>        ^
> >> 1 error generated.
> >>
> >
> > Try adding #include <sys/proc.h> if it's not already in the list.  It
> > may be that that file got included via pollution from some other header
> > file in the past and maybe now that has changed.
> >
> > If you're already including sys/proc.h then I'm clueless.
> 
> Thanks Ian, that appears to work.
> 
> Maurizio, can you apply the attached patch to a clean ports tree and see if isboot-kmod will build and function properly for you? This is all the changes from this thread and the previous one. If you let me know it works I'll get the port updated.
> 
> 
> Hi John, I need some help.
> 
> I am running:
>  # uname -a                    
> FreeBSD  12.0-CURRENT FreeBSD 12.0-CURRENT #0 r328383: Thu Jan 25 04:48:52 UTC 2018     root at releng3.nyi.freebsd.org:/usr/obj/usr/src/amd64.amd64/sys/GENERIC  amd64
> 
> after upgrading the ports tree with:
> # portsnap fetch update
> 
> I have copied the directory /usr/ports/net/isboot-kmod/ in  /root/src/isboot-kmod and /root/src/isboot-kmod.orig
> # ls -l /root/src
> total 6
> drwxr-xr-x  3 root  wheel     6 Feb  7 13:46 isboot-kmod
> drwxr-xr-x  3 root  wheel     6 Feb  7 13:46 isboot-kmod.orig
> -rw-rw-rw-  1 root  wheel  5630 Feb  7 11:38 isboot_patch.txt
> 
> Trying to apply the patch I obtain the error:
> # cd /root/src
> # patch -sC < isboot_patch.txt
> 2 out of 2 hunks failed while patching isboot-kmod/Makefile
> 5 out of 5 hunks failed while patching isboot-kmod/files/patch-isboot.c 
> 
> What I am missing ?
> Thanks again for your work.

Not sure but I ran in to similar issues testing here as well. Here's the "svn diff" patch which does work for me. Note that this one should be applied from within the isboot-kmod directory.

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: isboot-kmod-0.2.13_2.diff.txt
URL: <http://lists.freebsd.org/pipermail/freebsd-current/attachments/20180207/c774b4f0/attachment.txt>