nda(4) does not work (reliably) in VMware Workstation

[Chuck Tuffli]

On Sun, Dec 9, 2018 at 3:50 PM Chuck Tuffli <chuck at freebsd.org> wrote:

> On Sun, Dec 9, 2018 at 3:43 PM Yuri Pankov <yuripv at yuripv.net> wrote:
>
>> Chuck Tuffli wrote:
>> > On Sat, Dec 8, 2018 at 12:28 PM Yuri Pankov <yuripv at yuripv.net
>> > <mailto:yuripv at yuripv.net>> wrote:
>> >
>> >     Hi,
>> >
>> >     Running -HEAD in VMware Workstation 15.0.2 VM.  Trying to use nda(4)
>> >     instead of nvd(4) shows the following list of errors, and eventually
>> >     panics:
>> >
>> >     https://people.freebsd.org/~yuripv/nda1.png
>> >     https://people.freebsd.org/~yuripv/nda2.png
>> >
>> >     nvd(4) works without issues in this VM.  nda(4) works as well in
>> VMware
>> >     ESXi VMs.  Is this a problem with WS NVMe emulation?
>> >
>> >
>> > Since I don't have access to ESXi, the attached is a speculative fix. If
>> > it works, I'll clean this up a bit and get it committed. If not, please
>> > post the output from:
>> > nvmecontrol identtify nvme0
>>
>> Thank you, it seems to help (was seeing the issue previously immediately
>> after boot).  BTW, the ESXi VM works fine with nda, it's only the
>> Workstation that had the problem.  Comparing `nvmecontrol identify`
>> output from both, the only difference is (first is WS, second is ESXi):
>>
>> -Dataset Management Command:  Not Supported
>> +Dataset Management Command:  Supported
>>
>
> OK, that makes sense given the error message and the patch working. I'll
> get this cleaned up and committed. Thanks for the report!
>

Committed r342046 to address this

--chuck