svn commit: r325320 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs [breaks lld on zfs: lld uses fallocate]
Andriy Gapon
avg at FreeBSD.org
Sat Nov 4 12:10:34 UTC 2017
On 04/11/2017 13:41, Andriy Gapon wrote:
> On 04/11/2017 12:32, Mark Millard wrote:
>> if (int Err = ::posix_fallocate(FD, 0, Size)) {
>> if (Err != EOPNOTSUPP)
>> return std::error_code(Err, std::generic_category());
>> }
>
> The commit message that you didn't include into your reply contains some useful
> information that authors / maintainers of this code should probably take into
> account:
>
>> Please note that EINVAL is used to report that the underlying file system
>> does not support the operation (POSIX.1-2008).
>
> Here is a link for that:
> http://pubs.opengroup.org/onlinepubs/9699919799/functions/posix_fallocate.html
>
My response above is quite dry, so I want to add this.
Thank you very much for the deep analysis.
I am sorry for the trouble that my change caused, but I think that its root
cause lies elsewhere (lld, posix).
--
Andriy Gapon
More information about the freebsd-current
mailing list