src/libexec/Makefile damaged fails to build rshd

[Ngie Cooper (yaneurabeya)]

> On Aug 6, 2017, at 13:47, Julian H. Stacey <jhs at berklix.com> wrote:
> 
> Hi, Reference:
>> From:		"Julian H. Stacey" <jhs at berklix.com>
>> Date:		Sun, 06 Aug 2017 22:25:02 +0200
> 
> "Julian H. Stacey" wrote:
>>>>> The half baked mod. to src/libexec/Makefile could be backed out
>> 
>> I was wrong, sorry, code is not half baked, cos further down I spotted :
>> 	.if ${MK_RCMDS} != "no"
>> 	_rlogind=       rlogind
>> 	_rshd=          rshd
>> 	.endif
>> 
>> cd /usr/src; find . -type f | xargs grep MK_RCMDS | grep -v Makefile:
>> 	./tools/build/mk/OptionalObsoleteFiles.inc:.if ${MK_RCMDS} == no
>> 
>> I'm reading that while make world continues.
> 
> Finaly found it, after guessing some shell might roll MK_RCMDS from
> a list including RCMDS, & finding man src.conf with WITH_RCMDS
> Took me a while to find.  Thanks Ngie for your time.

Hi Julian,
	Oh, ok.
	Yes, the default for MK_RCMDS was changed recently from on to off. UPDATING also mentions it.
	You must have upgraded from a major version to another recently or over a several month period — MK_* has been enhanced quite a bit over the past few months to “better respect optional features”. I left things on by default for POLA sake, but you’re free to remove them as need be. The defaults may change in the future (as you discovered with MK_RCMDS).
Cheers,
-Ngie

$ svn blame ^/head/share/mk/src.opts.mk | grep RCMDS
320530        jlh     RCMDS \
$ svn log -c 320530 ^/
------------------------------------------------------------------------
r320530 | jlh | 2017-07-01 03:04:42 -0700 (Sat, 01 Jul 2017) | 12 lines

Disable RCMDS by default.

This was announced in this thread:
https://lists.freebsd.org/pipermail/freebsd-arch/2017-June/018239.html

Applying plan proposed by ngie@ in:
https://lists.freebsd.org/pipermail/freebsd-arch/2017-June/018249.html

The port has been submitted as net/bsdrcmds in r444814.

Approved by:    bapt, roberto, and others

------------------------------------------------------------------------
$ grep -n 20170701 -A 2 UPDATING
66:20170701:
67-     WITHOUT_RCMDS is now the default. Set WITH_RCMDS if you need them to be
68-     built with the base system.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 842 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.freebsd.org/pipermail/freebsd-current/attachments/20170806/7aea404a/attachment.sig>