r300912: compile failure in world: event.cc:438:45: error: invalid suffix on literal;

[Dimitry Andric]

On 28 May 2016, at 23:20, Alan Somers <asomers at freebsd.org> wrote:
> 
> On Sat, May 28, 2016 at 3:04 PM, O. Hartmann
> <ohartman at zedat.fu-berlin.de> wrote:
>> Recent CURRENT r300912 fails to buildworld with the error shown below:
>> 
>> [...]
>> cc   -O2 -pipe -O3 -O3 -pipe -march=native  -DNDEBUG -MD  -MF.depend.alias_skinny.o
>> -MTalias_skinny.o -std=gnu99 -fstack-protector-strong -Wsystem-headers -Wno-pointer-sign
>> -Wno-empty-body -Wno-string-plus-int -Wno-unused-const-variable -Wno-tautological-compare
>> -Wno-unused-value -Wno-parentheses-equality -Wno-unused-function -Wno-enum-conversion
>> -Wno-unused-local-typedef -Wno-switch -Wno-switch-enum -Wno-knr-promoted-parameter
>> -Wno-parentheses  -Qunused-arguments
>> -c /usr/src/lib/libalias/modules/skinny/../../../../sys/netinet/libalias/alias_skinny.c
>> -o alias_skinny.o --- all_subdir_lib/libdevdctl --- --- event.So
>> --- /usr/src/lib/libdevdctl/event.cc:438:45: error: invalid suffix on literal; C++11
>> requires a space between literal and identifier [-Wreserved-user-defined-literal]
>> snprintf(timebuf, bufsize, " timestamp=%"PRId64,
> 
> Those aren't the usual CFLAGS.  What are your environment, compiler,
> and target architecture?

There seems to be something that is adding -std=c++11 unconditionally to
the CXXFLAGS for a C++ library.  I'm adding Bryan on CC, who may know
how this comes to pass.

That said, putting a space between the double quote and PRId64
identifier would be handy in any case.

-Dimitry

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.freebsd.org/pipermail/freebsd-current/attachments/20160528/fc51e1b4/attachment.sig>