qsort() documentation

Warren Block wblock at wonkity.com
Mon Apr 18 18:56:31 UTC 2016


On Mon, 18 Apr 2016, Hans Petter Selasky wrote:

> Hi,
>
> Are there any objections adding the following as part of documenting our 
> kernel's qsort function?
>
> Index: sys/libkern/qsort.c
> ===================================================================
> --- sys/libkern/qsort.c (revision 298202)
> +++ sys/libkern/qsort.c (working copy)
> @@ -45,6 +45,10 @@
>
> /*
>  * Qsort routine from Bentley & McIlroy's "Engineering a Sort Function".
> + *
> + * NOTE: This implementation of qsort() was designed to not have the

"was designed to avoid the"

> + * worst case complexity of N**2, as seen with the regular quick sort
> + * functions as described by Wikipedia.
>  */

Why Wikipedia, specifically?  There are a lot of places that describe 
quicksort.  How about just

   Note: This implementation of qsort() is designed to avoid the
   worst-case complexity of N**2 that is often seen with standard
   versions.


More information about the freebsd-current mailing list