Mbuf leak in if_lagg.c

[Andrey V. Elsukov]

On 19.03.2015 19:31, Alexandre Martins wrote:
> Hi !
> 
> I found a leak of mbuf in the lagg driver :
> 
> https://svnweb.freebsd.org/base/head/sys/net/if_lagg.c?view=annotate#l1672
> 
> -=-=-=-=-=-=-=-=-=-=-
> m = (lp->lp_detaching == 0) ? lagg_proto_input(sc, lp, m) : NULL;
> -=-=-=-=-=-=-=-=-=-=-
> 
> If lp_detaching is non 0, the mbuf pointer is set to NULL without m_freem it.
> 
> Can you look at this ?

Hi,

what you thing about this patch?
lp_detaching can be non zero in case of parent interface departure.
So I don't see the reason to call ETHER_BPF_MTAP() in this case.

-- 
WBR, Andrey V. Elsukov
-------------- next part --------------
A non-text attachment was scrubbed...
Name: if_lagg.diff
Type: text/x-patch
Size: 802 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-current/attachments/20150326/0dc5aef2/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 538 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/freebsd-current/attachments/20150326/0dc5aef2/attachment.sig>