posix_fallocate(2) && posix_fadvise(2) are somewhat broken

[Garrett Wollman]

In article <CAH7qZfvV-RepAc6N0UxFi2RBthxrd+qHD-Qh5dc-9v=NFGCy_w at mail.gmail.com>
sobomax at freebsd.org writes:

>Hi, while working on some unrelated feature I've noticed that at least
>those two system calls are not returning proper value (-1) on error.
>Instead actual errno value is returned from the syscall verbatim,

That is what the specification requires.

RETURN VALUE
            Upon successful completion, posix_fadvise( ) shall return
            zero; otherwise, an error number shall be returned to
            indicate the error.

(Quote from SUSv7 p. 1410, lines 46221-46223.)

-GAWollman