[CFR][PATCH] drm2: don't assume that dev->driver->max_ioctl > *dev->driver->compat_ioctls_nr

Eygene Ryabinkin rea at freebsd.org
Fri Nov 28 13:29:53 UTC 2014


Konstantin, *, good day.

I noticed that the current ioctl processing code for drm2 implicitely
assumes that the number of native ioctls is higher than that of 32-bit
compat ones, so it immediately gives EINVAL when
nr >= dev->driver->max_ioctl.  Seems that in future such assumption
may not be true in all cases.

This can be fixed with the following patch:
  http://codelabs.ru/fbsd/patches/drm2/drm_drv-untangle-32bit-compat.diff

Any thoughts on it?

Thanks.
-- 
Eygene Ryabinkin                                        ,,,^..^,,,
[ Life's unfair - but root password helps!           | codelabs.ru ]
[ 82FE 06BC D497 C0DE 49EC  4FF0 16AF 9EAE 8152 ECFB | freebsd.org ]
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 343 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-current/attachments/20141128/5ce160c0/attachment.sig>


More information about the freebsd-current mailing list