CFR: AES-GCM and OpenCrypto work review

[John-Mark Gurney]

John-Mark Gurney wrote this message on Fri, Nov 14, 2014 at 11:39 -0800:
> Well.. It looks like IPSEC is still broken in head...  I can get
> pings to pass, but now on IPv4 transport mode, I can't get syn's to
> be sent out...  I see the output packet in the protocol stats, but
> no packets go out the interface...
> 
> If you could provide me w/ a simple set of spdadd commands, or the
> dumps from the machine, that'd be good...
> 
> Hmm....  I just ran ping -f so I could generate some traffic, and
> managed to get a:
> panic: System call sendto returing with kernel FPU ctx leaked
> 
> I'll look into this...

I just verified that this happens on a clean HEAD @ r274534:
FreeBSD 11.0-CURRENT #0 r274534: Fri Nov 14 17:17:10 PST 2014
    jmg at carbon.funkthat.com:/scratch/jmg/clean/sys/amd64/compile/IPSEC amd64

No modifications, nothing, and I got the same panic:
panic: System call sendto returing with kernel FPU ctx leaked
cpuid = 0
KDB: stack backtrace:
db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfffffe001de7a800
kdb_backtrace() at kdb_backtrace+0x39/frame 0xfffffe001de7a8b0
vpanic() at vpanic+0x189/frame 0xfffffe001de7a930
kassert_panic() at kassert_panic+0x139/frame 0xfffffe001de7a9a0
amd64_syscall() at amd64_syscall+0x616/frame 0xfffffe001de7aab0
Xfast_syscall() at Xfast_syscall+0xfb/frame 0xfffffe001de7aab0
--- syscall (64, FreeBSD ELF64, nosys), rip = 0x8011975aa, rsp = 0x7ffffffee588, rbp = 0x7ffffffee5c0 ---
KDB: enter: panic

So, it's clearly not my patch that is causing the issue...

Andrey, can you verify that you do not receive the same panic w/o my
patches?

-- 
  John-Mark Gurney				Voice: +1 415 225 5579

     "All that I will do, has been done, All that I have, has not."