[PATCH] NAND Framework ONFI chip detection

[Alexander Fedorov]

Hi all!

I'm writing NAND Flash controller driver for my Hackberry board.
And I found that NAND Framework does not properly detecting ONFI
compiliant chips.

First, ONFI specification says (p. 40
http://www.onfi.org/~/media/ONFI/specs/ONFI_1_0_Gold.pdf):

>The ONFI signature is the ASCII encoding of 'ONFI' where 'O' = 4Fh, 'N' = 4Eh, 'F' = 46h, 'I' = 49h.

But, current code check it for 'o', 'n', 'f', 'I'.

Second, function "onfi_read_parameter" (nand_generic.c) read
parameters page using this construction:
>NANDBUS_READ_BUFFER(nandbus, params, sizeof(struct onfi_params));

So, structure onfi_params must be declared as packed.

Proposed patch solves the problem for me.
Is this patch ok?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: nand_framework_onfi_probing.patch
Type: application/octet-stream
Size: 721 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-current/attachments/20130521/b6c973ee/attachment.obj>