[head tinderbox] failure on i386/i386

[Jeff Roberson]

On Sun, 12 May 2013, David Wolfskill wrote:

> It appears that the issue is i386- (or 32-bit-) specific.
>
> On Sun, May 12, 2013 at 07:16:48AM -0700, David Wolfskill wrote:
>> On Sun, May 12, 2013 at 11:45:37AM +0000, FreeBSD Tinderbox wrote:
>>> TB --- 2013-05-12 05:50:18 - tinderbox 2.10 running on freebsd-current.sentex.ca
>>> TB --- 2013-05-12 05:50:18 - FreeBSD freebsd-current.sentex.ca 8.3-PRERELEASE FreeBSD 8.3-PRERELEASE #0: Mon Mar 26 13:54:12 EDT 2012     des at freebsd-current.sentex.ca:/usr/obj/usr/src/sys/GENERIC  amd64
>>> TB --- 2013-05-12 05:50:18 - starting HEAD tinderbox run for i386/i386
>>> TB --- 2013-05-12 05:50:18 - cleaning the object tree
>>> TB --- 2013-05-12 05:50:18 - /usr/local/bin/svn stat /src
>>> TB --- 2013-05-12 05:50:23 - At svn revision 250553
>>> TB --- 2013-05-12 05:50:24 - building world
>> ...
>> ...
>> ctfconvert -L VERSION -g vfs_lookup.o
>> clang -c -O -pipe  -std=c99 -g -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -Wundef -Wno-pointer-sign -fformat-extensions  -Wmissing-include-dirs -fdiagnostics-show-option  -Wno-error-tautological-compare -Wno-error-empty-body  -Wno-error-parentheses-equality -nostdinc  -I. -I/usr/src/sys -I/usr/src/sys/contrib/altq -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h  -mno-aes -mno-avx -mno-mmx -mno-sse -msoft-float -ffreestanding -fstack-protector -Werror  /usr/src/sys/kern/vfs_mountroot.c
>> :> export_syms
>> awk -f /usr/src/sys/conf/kmod_syms.awk drm2.kld  export_syms | xargs -J% objcopy % drm2.kld
>> clang -c -O -pipe  -std=c99 -g -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -Wundef -Wno-pointer-sign -fformat-extensions  -Wmissing-include-dirs -fdiagnostics-show-option  -Wno-error-tautological-compare -Wno-error-empty-body  -Wno-error-parentheses-equality -nostdinc  -I. -I/usr/src/sys -I/usr/src/sys/contrib/altq -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h  -mno-aes -mno-avx -mno-mmx -mno-sse -msoft-float -ffreestanding -fstack-protector -Werror  /usr/src/sys/kern/vfs_subr.c
>> ctfconvert -L VERSION -g vfs_mount.o
>> /usr/src/sys/kern/vfs_subr.c:305:1: error: '__assert_4' declared as an array with a negative size
>> PCTRIE_DEFINE(BUF, buf, b_lblkno, buf_trie_alloc, buf_trie_free);
>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> /usr/src/sys/sys/pctrie.h:40:66: note: expanded from macro 'PCTRIE_DEFINE'
>> CTASSERT(sizeof(((struct type *)0)->field) == sizeof(uint64_t));        \
>>                                                                         ^
>> /usr/src/sys/sys/systm.h:100:21: note: expanded from macro '\
>> CTASSERT'
>> #define CTASSERT(x)     _Static_assert(x, "compile-time assertion failed")
>>                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> /usr/src/sys/sys/cdefs.h:251:30: note: expanded from macro '_Static_assert'
>> #define _Static_assert(x, y)    __Static_assert(x, __COUNTER__)
>>                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> /usr/src/sys/sys/cdefs.h:252:31: note: expanded from macro '__Static_assert'
>> #define __Static_assert(x, y)   ___Static_assert(x, y)
>>                                 ^~~~~~~~~~~~~~~~~~~~~~
>> /usr/src/sys/sys/cdefs.h:253:60: note: expanded from macro '___Static_assert'
>> #define ___Static_assert(x, y)  typedef char __assert_ ## y[(x) ? 1 : -1]
>>                                                             ^~~~~~~~~~~~
>> 1 error generated.
>> *** [vfs_subr.o] Error code 1
>> ....
>>
>>
>> Based on the above, I reverted r250551 and re-started the "make
>> buildkernel" -- which succeeded:
>>
>> FreeBSD g1-227.catwhisker.org 10.0-CURRENT FreeBSD 10.0-CURRENT #897  r250557M/250558:1000032: Sun May 12 06:44:01 PDT 2013     root at g1-227.catwhisker.org:/usr/obj/usr/src/sys/CANARY  i386
>> ....
>
> However, I did not need to revert r250551 to build successfully on amd64:
>
> FreeBSD g1-227.catwhisker.org 10.0-CURRENT FreeBSD 10.0-CURRENT #2  rM/:1000032: Sun May 12 10:09:59 PDT 2013     root at g1-227.catwhisker.org:/usr/obj/usr/src/sys/CANARY  amd64
>

Thanks.  It looks like it's actually an alignment problem and that compile 
error is erroneous.  I'm going to check in a fix by weakening the 
alignment requirement to 32bit and then build locally but I will probably 
race tinderbox to verify that it resolves 32bit.

Jeff

> Peace,
> david
> -- 
> David H. Wolfskill				david at catwhisker.org
> Taliban: Evil men with guns afraid of truth from a 14-year old girl.
>
> See http://www.catwhisker.org/~david/publickey.gpg for my public key.
>