[patch]: RFC changing order for khelp modules

Maksim Yevmenkin maksim.yevmenkin at gmail.com
Thu May 3 20:00:06 UTC 2012


hello,

would anyone object to the following patch?

==

--- sys/module_khelp.h  (revision 582)
+++ sys/module_khelp.h  (working copy)
@@ -83,7 +83,7 @@
                .priv = &kmd_##hname                                    \
        };                                                              \
        DECLARE_MODULE(hname, h_##hname, SI_SUB_PROTO_IFATTACHDOMAIN,   \
-           SI_ORDER_ANY);                                              \
+           SI_ORDER_MIDDLE);                                           \
        MODULE_VERSION(hname, version)

 #define        KHELP_DECLARE_MOD_UMA(hname, hdata, hhooks, version,
size, ctor, dtor) \
@@ -102,7 +102,7 @@
                .priv = &kmd_##hname                                    \
        };                                                              \
        DECLARE_MODULE(hname, h_##hname, SI_SUB_PROTO_IFATTACHDOMAIN,   \
-           SI_ORDER_ANY);                                              \
+           SI_ORDER_MIDDLE);                                           \
        MODULE_VERSION(hname, version)


==

the issue i stumbled upon is that when i compile in all available tcp
congestion control algorithms into the kernel (instead of using them
as modules) a couple of those fail to initialize and register because
they fail to find h_ertt khelp module (which is also complied in)

thanks,
max


More information about the freebsd-current mailing list