[PATCH] Add locking to twe(4) so it no longer uses Giant

[Mike Tancsa]

On 8/9/2012 3:28 PM, Mike Tancsa wrote:
> On 8/9/2012 1:21 PM, John Baldwin wrote:
>>
>> Humm, I wonder if this module has a mix of old and new .o files somehow?
>> Perhaps try rebuilding twe.ko from scratch after doing a 'make clean'?
> 
> I think you are right. I nuked all the kernel files and recompiled
> again, and it no longer panics and I see the entry in /dev now!?
> 
> 0{offsite2}# kldload twe
> twe0: <3ware Storage Controller. Driver version 1.50.01.002> port
> 0x2000-0x200f mem 0xe2810000-0xe281000f,0xe2000000-0xe27fffff at device
> 0.0 on pci6
> twe0: [GIANT-LOCKED]
> twe0: 2 ports, Firmware FE8S 1.05.00.068, BIOS BE7X 1.08.00.048
> twe0: Calling make_dev()
> twe0: make_dev() returned 0xfffffe0122105200 (twe0)
> twed0 on twe0
> twed0: 953878MB (1953542144 sectors)
> 0{offsite2}#


OK, some more mystery.


If I load it as a kld,

I see the device. (Note, I added MDT into the version string)

0{offsite2}# twe0: <3ware Storage Controller. Driver version
1.50.01.002MDT> port 0x2000-0x200f mem
0xe2810000-0xe281000f,0xe2000000-0xe27fffff at device 0.0 on pci6
twe0: 2 ports, Firmware FE8S 1.05.00.068, BIOS BE7X 1.08.00.048
twe0: Calling make_dev()
twe0: make_dev() returned 0xfffffe0026581a00 (twe0)
twed0 on twe0
twed0: 953878MB (1953542144 sectors)

0{offsite2}# ls -l /dev/tw*
crw-------  1 root  operator  -   0,  37 Aug  9 16:58 /dev/twa0
crw-------  1 root  operator  -   0, 173 Aug  9 17:00 /dev/twe0
crw-r-----  1 root  operator  -   0, 174 Aug  9 17:00 /dev/twed0



Start up the tw_cli client

0{offsite2}# tw_cli
//offsite2> show

Ctl   Model        (V)Ports  Drives   Units   NotOpt  RRate   VRate  BBU
------------------------------------------------------------------------
c0    9650SE-2LP   2         2        1       0       1       1      -


//offsite2> exit
0{offsite2}# ls -l /dev/tw*
crw-------  1 root  operator  -   0,  37 Aug  9 16:58 /dev/twa0
crw-r-----  1 root  operator  -   0, 174 Aug  9 17:00 /dev/twed0
0{offsite2}#


It then disappears ?!

	---Mike



-- 
-------------------
Mike Tancsa, tel +1 519 651 3400
Sentex Communications, mike at sentex.net
Providing Internet services since 1994 www.sentex.net
Cambridge, Ontario Canada   http://www.tancsa.com/